Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RTCPFeedback support to PopulateFromSDP #1000

Merged
merged 1 commit into from Feb 5, 2020
Merged

Conversation

encounter
Copy link
Contributor

Handles the newly added RTCPFeedback information from pion/sdp

Handles the newly added RTCPFeedback information from pion/sdp
@codecov-io
Copy link

Codecov Report

Merging #1000 into master will increase coverage by 3.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1000      +/-   ##
==========================================
+ Coverage   74.39%   77.45%   +3.06%     
==========================================
  Files          66       59       -7     
  Lines        5003     4405     -598     
==========================================
- Hits         3722     3412     -310     
+ Misses        959      714     -245     
+ Partials      322      279      -43
Flag Coverage Δ
#go 77.45% <100%> (+0.77%) ⬆️
#wasm ?
Impacted Files Coverage Δ
mediaengine.go 95.14% <100%> (+17.08%) ⬆️
sctptransport.go 75.38% <0%> (-3.59%) ⬇️
peerconnection_js.go
datachannel_js_detach.go
iceserver_js.go
js_utils.go
datachannel_js.go
settingengine_js.go
api_js.go
peerconnection.go 73.54% <0%> (+0.35%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05238e4...ca84f9f. Read the comment docs.

Copy link
Member

@Sean-Der Sean-Der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work! This is going to be really helpful when I start the BWE stuff.

@encounter encounter merged commit ce8de08 into master Feb 5, 2020
@encounter encounter deleted the rtcp-feedback branch February 5, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants