From 8169017b223976b9435afa1ef07cbf564a6ac607 Mon Sep 17 00:00:00 2001 From: ypothoma Date: Fri, 8 Dec 2023 14:21:40 -0800 Subject: [PATCH 1/3] Negotiated codecs should not be restricted to first codec found --- mediaengine.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mediaengine.go b/mediaengine.go index 5e5a2bfdfb..03d6f939c5 100644 --- a/mediaengine.go +++ b/mediaengine.go @@ -490,10 +490,10 @@ func (m *MediaEngine) updateFromRemoteDescription(desc sdp.SessionDescription) e for _, media := range desc.MediaDescriptions { var typ RTPCodecType switch { - case !m.negotiatedAudio && strings.EqualFold(media.MediaName.Media, "audio"): + case strings.EqualFold(media.MediaName.Media, "audio"): m.negotiatedAudio = true typ = RTPCodecTypeAudio - case !m.negotiatedVideo && strings.EqualFold(media.MediaName.Media, "video"): + case strings.EqualFold(media.MediaName.Media, "video"): m.negotiatedVideo = true typ = RTPCodecTypeVideo default: From c64d26749ac19985c8b0ae0eac9323ce42df0efa Mon Sep 17 00:00:00 2001 From: ypothoma Date: Tue, 12 Dec 2023 08:49:57 -0800 Subject: [PATCH 2/3] Trigger CI --- rtpreceiver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtpreceiver.go b/rtpreceiver.go index f7d83d6fae..6e7540ad84 100644 --- a/rtpreceiver.go +++ b/rtpreceiver.go @@ -72,7 +72,7 @@ type RTPReceiver struct { rtxPool sync.Pool } -// NewRTPReceiver constructs a new RTPReceiver +// NewRTPReceiver constructs a new RTPReceiver // func (api *API) NewRTPReceiver(kind RTPCodecType, transport *DTLSTransport) (*RTPReceiver, error) { if transport == nil { return nil, errRTPReceiverDTLSTransportNil From 50e3727d58f9124513177426033f0888f2ea5c4a Mon Sep 17 00:00:00 2001 From: ypothoma Date: Tue, 12 Dec 2023 08:50:17 -0800 Subject: [PATCH 3/3] Trigger CI --- rtpreceiver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtpreceiver.go b/rtpreceiver.go index 6e7540ad84..f7d83d6fae 100644 --- a/rtpreceiver.go +++ b/rtpreceiver.go @@ -72,7 +72,7 @@ type RTPReceiver struct { rtxPool sync.Pool } -// NewRTPReceiver constructs a new RTPReceiver // +// NewRTPReceiver constructs a new RTPReceiver func (api *API) NewRTPReceiver(kind RTPCodecType, transport *DTLSTransport) (*RTPReceiver, error) { if transport == nil { return nil, errRTPReceiverDTLSTransportNil