Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine rtx support #2664

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Refine rtx support #2664

merged 1 commit into from
Feb 5, 2024

Conversation

cnderrauber
Copy link
Member

@cnderrauber cnderrauber commented Feb 5, 2024

Always handle header extensions from packet read
from interceptor, let interceptor has consistent
chance to process headers

Fix rtx is not negotiated when there is multiple
codecs has same mime but different profile (H264)

Fix rtx stream info missed when SSRC group attr
shows after base track's ssrc attr.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f7dd0f) 76.43% compared to head (cbf0beb) 64.54%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2664       +/-   ##
===========================================
- Coverage   76.43%   64.54%   -11.89%     
===========================================
  Files          87       64       -23     
  Lines        9908     3689     -6219     
===========================================
- Hits         7573     2381     -5192     
+ Misses       1865     1180      -685     
+ Partials      470      128      -342     
Flag Coverage Δ
go ?
wasm 64.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@boks1971 boks1971 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

mediaengine_test.go Show resolved Hide resolved
Always handle header extensions from packet read
from interceptor, let interceptor has consistent
chance to process headers

Fix rtx is not negotiated when there is multiple
codecs has same mime but different profile (H264)

Fix rtx stream info missed when SSRC group attr
shows after base track's ssrc attr.
@cnderrauber cnderrauber merged commit 2407bf2 into master Feb 5, 2024
16 of 17 checks passed
@cnderrauber cnderrauber deleted the refine_rtx branch February 5, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants