New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Barnard's Star's Faction is 'Independent' instead of 'Federation' #1620

Closed
skapusniak opened this Issue Oct 21, 2012 · 4 comments

Comments

Projects
None yet
4 participants
@skapusniak

skapusniak commented Oct 21, 2012

This seems a wee bit odd for an Earth Federation Prison Colony, under Earth Colonial Rule.

I couldn't see a way to set the faction from in the custom system definition, I'm guessing that's not possibly currently?

@walterar

This comment has been minimized.

Show comment
Hide comment
@walterar

walterar Oct 21, 2012

Contributor

You probe eliminate (or comment) this line :govtype ('EARTH COLONIAL'), in the file /pioneer/data/systems/custom/00_barnard_s_star.lua

Contributor

walterar commented Oct 21, 2012

You probe eliminate (or comment) this line :govtype ('EARTH COLONIAL'), in the file /pioneer/data/systems/custom/00_barnard_s_star.lua

@skapusniak

This comment has been minimized.

Show comment
Hide comment
@skapusniak

skapusniak Oct 21, 2012

Yes, that would likely work, but I'm currently shooting for something a bit more ambitious, altering the factions code to take multiple government types instead. From my reading of the code, if the system is custom then it uses the government type to set the faction, so if you were able to have multiple government types per faction, then you could set the Federation faction to include both Earth Democracy and Earth Colonial.

Of course given my lousy C++ skills, all I've got to show for it so far is a freeze on opening the map, but that is quite an advance on not being able to build at all this morning, and the freeze on starting the game I was getting an hour ago :)

I don't really don't guarantee anything will come of this tho'.

skapusniak commented Oct 21, 2012

Yes, that would likely work, but I'm currently shooting for something a bit more ambitious, altering the factions code to take multiple government types instead. From my reading of the code, if the system is custom then it uses the government type to set the faction, so if you were able to have multiple government types per faction, then you could set the Federation faction to include both Earth Democracy and Earth Colonial.

Of course given my lousy C++ skills, all I've got to show for it so far is a freeze on opening the map, but that is quite an advance on not being able to build at all this morning, and the freeze on starting the game I was getting an hour ago :)

I don't really don't guarantee anything will come of this tho'.

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Oct 22, 2012

Contributor

if the system is custom then it uses the government type to set the faction

That's correct. The idea was that you could have small pockets of systems belonging to another faction within the procedurally assigned volume of an opposing faction.

so if you were able to have multiple government types per faction, then you could set the Federation faction to include both Earth Democracy and Earth Colonial.

That sounds like a good idea, I hadn't considered grouping multiple "Earth XXXX" types together.

Contributor

fluffyfreak commented Oct 22, 2012

if the system is custom then it uses the government type to set the faction

That's correct. The idea was that you could have small pockets of systems belonging to another faction within the procedurally assigned volume of an opposing faction.

so if you were able to have multiple government types per faction, then you could set the Federation faction to include both Earth Democracy and Earth Colonial.

That sounds like a good idea, I hadn't considered grouping multiple "Earth XXXX" types together.

@lwho

This comment has been minimized.

Show comment
Hide comment
@lwho

lwho Jan 19, 2014

Contributor

This has been solved some time ago.
->closed

Contributor

lwho commented Jan 19, 2014

This has been solved some time ago.
->closed

@lwho lwho closed this Jan 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment