Terrain using new VertexBuffer #2795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al into it's draw method rather than setting it all outside of it.
|
Ping @Luomu :) |
| if (m_needUpdateVBOs) { | ||
| assert(renderer); | ||
| assert(radius>0.0); |
There was a problem hiding this comment.
Cannot compile, radius not defined in this scope
There was a problem hiding this comment.
So I suppose, this means MSVS project files do not enable assertions. Normally we include assertions even in release builds (at least Linux and the official Windows builds do).
|
Otherwise OK 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch over to using the new VertexBuffer and IndexBuffer types for the terrain patches.
Pass the material into it's draw method rather than setting it all outside of it in GeoSphere.