New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The scanner remains active on screen when changing ship. #3027
Comments
Confirmed. Equipment isn't properly cleared when you change a ship and remains usable even if not present on the new ship - this isn't limited to scanner. Buying and selling the problematic piece equipment after the bug occurs doesn't change anything. |
Yep. I'm not at any computer right now but I know what's going on. Basically, when replacing the ship, the core just replaces the EquipSet with a new, empty one, without caring about what was installed. Thus, the stuff doesn't get uninstalled. (I'm not at my computer right now and not in a shape to write code anyway, so i can't fix it right away) I'd fix it by writing a EquipSet:Clear(ship) method that would uninstall every single piece of equipment from the equipset (and from the ship given as argument), by walking through all the This might be a good exercise to get accointed with the internals of EquipSet, and also on how to call a Lua method from C++ using the advanced tooling developed along with new-equipment (the CallMethod stuff). I'll be AFK for the next couple of days, although probably still reachable via IRC through my mobile phone if need be. |
Ok. Meanwhile... I'm not sure how to migrate this, to new code: |
@walterar I think that question is not related to this bug, so this issue is not the right place for it, but I have answered on the forum, thread New equipment migration questions |
It does not work. Maybe I should open an new issue. |
#3052 fix this. |
.
The text was updated successfully, but these errors were encountered: