New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themisto mass problem in Sol #4323

Open
macksting opened this Issue Apr 8, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@macksting

macksting commented Apr 8, 2018

Observed behaviour

Game attempted and failed to produce a flawless Themisto, presumably the moon of Jupiter

import [modules/TradeShips.lua]: modules/TradeShips.lua did not return anything
GalaxyGenerator::Init()
Creating new galaxy generator 'legacy' version 1
Error: Custom system definition: Value cannot be negative/zero (0.000000) for Themisto : mass
Number of factions added: 103
StarSystemCache: misses: 0, slave hits: 0, master hits: 0
SectorCache: misses: 101, slave hits: 0, master hits: 2

Expected behaviour

Themisto should have non-zero/negative mass or be somehow spawned anyway

Steps to reproduce

Start game, read terminal text

My pioneer version (and OS):
build: git (8600607) on Lubuntu 16.04

@macksting macksting changed the title from Custom system Themisto mass problem to Custom Themisto mass problem Apr 8, 2018

@nozmajner nozmajner changed the title from Custom Themisto mass problem to Themisto mass problem in Sol Apr 8, 2018

@jaj22

This comment has been minimized.

Contributor

jaj22 commented Apr 9, 2018

The root problem is that Themisto is so small that it's not represented as a non-zero mass in 32.32 fixed point earth masses. Zero-mass objects generally do work fine though, even as reference frames: Space stations are all zero-mass, for example.

Last time I checked, Themisto was still spawned (with zero mass). Is this the case, or is it missing now?

@fluffyfreak

This comment has been minimized.

Contributor

fluffyfreak commented Apr 9, 2018

I think they get spawned, it's just a warning to us to fix it (if possible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment