New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the game reports that cargo has been jettisoned for missions that don't exist #4423

Open
42triangles opened this Issue Aug 27, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@42triangles
Contributor

42triangles commented Aug 27, 2018

Observed behaviour

Upon landing at the target (in the save file Mexico City), you get informed that you have jettisoned someones cargo and have to pay for it, even though that mission either never existed or was completed earlier.

Expected behaviour

The "ghost mission" shouldn't exist in the first place.

Steps to reproduce

Open the save file (after decompressing it) and land in Mexico City.

My pioneer version (and OS):
commit d50f1ee in this repository, NixOS (Linux)

The version in which the save file was created is a little older though, but not older than 67dcbce.

@42triangles

This comment has been minimized.

Contributor

42triangles commented Aug 27, 2018

I've already done some digging, and I suspect that the bug only happens because auto saves are enabled.

Other than that: The mission exists solely in the CargoRun module, and not in the actual mission list. So the behaviour on landing when you get to Mexico City in the save file is correct, but either

  • the behaviour when landing when you first do the mission, or
  • the behaviour when saving/loading missions in CargoRun

is at fault.

I first thought that that might be a race condition, but this seems to not be the case since events are handled in order. If it is, it would need to happen between these two lines.

I've not yet found a way to reproduce the actual issue at hand, but I still try to. (I've tried it doing normal gameplay with auto save enabled, and checking if there is a ghost mission)

I'm still trying to fix this issue myself, but if there are any tips or ideas, let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment