New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure --with-strip fails #4504

Open
orbea opened this Issue Dec 27, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@orbea
Contributor

orbea commented Dec 27, 2018

Observed behaviour

When configuring pioneer with ./configure --with-strip it will fail.

config.status: executing depfiles commands
config.status: error: in `/tmp/pioneer':
config.status: error: Something went wrong bootstrapping makefile fragments
    for automatic dependency tracking.  Try re-running configure with the
    '--disable-dependency-tracking' option to at least be able to build
    the package (albeit without support for automatic dependency tracking).
See `config.log' for more details

Full log: https://pastebin.com/x9ERwCPP

If --with-strip is omitted or if --disable-dependency-tracking is also used then configure will succeed, but neither is ideal.

I bisected this and found the first bad commit.

ec70cd27bd7e3d50db97c07f85ea8693b22dad25 is the first bad commit
commit ec70cd27bd7e3d50db97c07f85ea8693b22dad25
Author: Webster Sheets <webster@web-eworks.com>
Date:   Sat Sep 29 12:15:56 2018 -0400

    Fix some crashes relating to loading old saves.
    
    Catch JSON type errors in LuaGame.cpp.
    
    Apparently, Autotools doesn't like tabs. Who'da thunk it?
    
    Fixup the saved game loading code.
    
    Fix save loading errors, patch JSON library to throw instead of asserting.
    
    Theoretically finally fix the serialization code.
    
    String lifespan fix in unpickle_json

:040000 040000 cd403501c8b38853d57d934faace3117390a7b88 49c367d279268936e84b145c73078f578b04f0d4 M	contrib
:040000 040000 32b9b72d164525ed7d0207b2357bfbc485cc57b4 d382017f500705624cf2fbfde433c0a6dcd32f5d M	data
:040000 040000 4e44c821d5228d390c1c36b7aac00c8b0ee92bcc 625dccd4d10702c1dda2a9418cfa1a0fad49998b M	src

ec70cd2

Expected behaviour

pioneer should configure with --with-strip enabled.

Steps to reproduce

  1. ./bootstrap
  2. ./configure --with-strip

My pioneer version (and OS):

pioneer: 3fdd945
OS: Slackware64-current

@orbea

This comment has been minimized.

Contributor

orbea commented Dec 27, 2018

@Web-eWorks Do you have any ideas about this?

@Web-eWorks

This comment has been minimized.

Contributor

Web-eWorks commented Dec 27, 2018

@orbea I'm not sure what's going wrong here. It might be related to the json lib being a header-only library, but I'm not really familiar with autotools.

For reference, the autotools build system is currently being deprecated in favor of CMake. You're more than welcome to submit a fix for this issue if you find one, however.

@orbea

This comment has been minimized.

Contributor

orbea commented Dec 27, 2018

I wasn't aware that cmake was added until after I made the issue, I'm considering switching my build script to use cmake as a result. However this probably should remain open until its fixed or the autotools build is removed.

@orbea

This comment has been minimized.

Contributor

orbea commented Dec 28, 2018

@Web-eWorks

And cmake might not be an option...

[100%] Built target pioneer
make[2]: *** [CMakeFiles/modelcompiler.dir/build.make:101: modelcompiler] Segmentation fault
make[2]: *** Deleting file 'modelcompiler'
make[1]: *** [CMakeFiles/Makefile2:118: CMakeFiles/modelcompiler.dir/all] Error 2
make: *** [Makefile:130: all] Error 2
@orbea

This comment has been minimized.

Contributor

orbea commented Dec 28, 2018

The problem is here...

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 2b9116138..af03ab38b 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -240,11 +240,11 @@ set_target_properties(${PROJECT_NAME} modelcompiler savegamedump pioneerLib PROP
 
 # Optimize the models after the modelcompiler is built.
 # This really shouldn't be done inside the source tree...
-add_custom_command(TARGET modelcompiler POST_BUILD
-       COMMAND modelcompiler -b inplace
-       WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
-       COMMENT "Optimizing models" VERBATIM
-)
+#add_custom_command(TARGET modelcompiler POST_BUILD
+#      COMMAND modelcompiler -b inplace
+#      WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+#      COMMENT "Optimizing models" VERBATIM
+#)
 

I suppose I should make a new issue...

Edit: Done #4506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment