Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pioneer crashes if you hyperspace with the sector map open #4544

Open
ElonSatoshi opened this Issue Feb 23, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@ElonSatoshi
Copy link

ElonSatoshi commented Feb 23, 2019

Observed behaviour

Pioneer crashes if I hyperspace with the sector map open, with this error:

Started hyperspacing...
error: [string "[T] @pigui/modules/system-overview-window.lua..."]:178: attempt to index field 'system' (a nil value)
stack traceback:
        [string "[T] @pigui/modules/system-overview-window.lua..."]:178: in function 'fun'
        [string "[T] @pigui/game.lua"]:680: in function 'callModules'
        [string "[T] @pigui/game.lua"]:980: in function 'fun'
        [string "[T] @pigui/pigui.lua"]:72: in function 'window'
        [string "[T] @pigui/game.lua"]:959: in function 'fun'
        [string "[T] @pigui/pigui.lua"]:109: in function 'withStyleColors'
        [string "[T] @pigui/game.lua"]:958: in function 'game'
        [string "[T] @pigui/pigui.lua"]:129: in function <[string "[T] @pigui/pigui.lua"]:127>

Expected behaviour

I would expect it to switch to the cool HUDless hyperspace transition screen. Or better yet, as a new feature it could display an animation in the sector map showing the vessel transitioning through the hyperspace route.

Steps to reproduce

  1. Checkout the commit hash mentioned below and compile with cmake.
  2. Open Pioneer in a scenario with a spacecraft that has a hyperdrive
  3. Target a nearby star system for hyperspace.
  4. Launch, fly high enough to go into hyperspace.
  5. Hit the hyperspace button and then, while it's still counting down, open the sector map

My pioneer version (and OS):
Pioneer commit 0072a09 on Ubuntu 18.04.2 LTS x86_64

@nozmajner

This comment has been minimized.

Copy link
Contributor

nozmajner commented Feb 23, 2019

Animating it in the sector map would certainly look cool. But if that happens, care should be taken so it never implies any interacrivity regarding hyperspace travel I think.

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Feb 23, 2019

I assume a simpler fix would just be to have the player "not exist" when in hyperspace, or forbid showing the sector view when in hyper space. have it be just a blank screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.