Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of ships for sale updates on savegame load (exploitable?) #4673

Open
craigo- opened this issue Sep 15, 2019 · 4 comments

Comments

@craigo-
Copy link
Contributor

commented Sep 15, 2019

Observed behaviour

When loading a saved game, the list of ships available for sale immediately changes.

This is sort of exploitable and makes the scarcity of whatever ship the player is looking for pretty much negligible... The player can always close / reload / view ship market until they find what they want.

Expected behaviour

The list of ships for sale becomes part of the savefile (if it isn't already), and is restored when loading.

Background: I was hopping around a system's starports with a wad of cash, looking for a nice example of a Mola Mola, the ship of my dreams! Turns out they are quite hard to find. After about 8 local missions, I found one, but ughh, the colour! So I rage quit took a break. When I eventually came back and had another look at the ship market, the Mola Mola was gone. But it only took until the next game load before I was presented with another one.

Steps to reproduce

  • Start game
  • Observe the ships available in the ship market
  • Save game
  • End game
  • Load game
  • Observe the ships now available in the ship market (they will be different)

My pioneer version (and OS):
Pioneer 20190203 (latest release) and Pioneer master (6fd8f02), Release x64
Windows 10 Enterprise 1809 x64

@impaktor

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

ping @vakhoir

@vakhoir

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

I noticed (and exploited, I'm a bad boy) that bug a few months ago. I think the logic is handled by the space station script, not the market.

I've been a bit busy recently, but I can try and take a look at this this week.

@impaktor

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

OK, I assumed it would be introduced by the shipmarket re-write merged yesterday.
Thanks!

@Cyborgscode

This comment has been minimized.

Copy link

commented Oct 12, 2019

it's confirmed for 20191009 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.