Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External view clips into station geometry when docked #4700

Open
Cyborgscode opened this issue Oct 10, 2019 · 9 comments

Comments

@Cyborgscode
Copy link

@Cyborgscode Cyborgscode commented Oct 10, 2019

OS: Fedora 29
Version: 2019-10-09

when docked in a station, the external cam position is "unlucky" choosen:

Pioneer-Externalcamproblem

Please mve it back to something more usefull ;)

@Cyborgscode

This comment has been minimized.

Copy link
Author

@Cyborgscode Cyborgscode commented Oct 10, 2019

You don't wanne see the REAR View... it's mostly BLACK, because cam position is inside the walls.

@impaktor

This comment has been minimized.

Copy link
Member

@impaktor impaktor commented Oct 21, 2019

So basically, this could be seen as a feature request where the distance between external view camera and player is variable and bound to some key pair, possibly on numpad, as that's where camera control resides, if I remember correctly.

(I assume that would be the easiest fix, rather than have some code that checks collision detection with external camera, and try to move it to something else)

@nozmajner

This comment has been minimized.

Copy link
Contributor

@nozmajner nozmajner commented Oct 21, 2019

You can already move the camera closer or further. Numpad +-.

@impaktor

This comment has been minimized.

Copy link
Member

@impaktor impaktor commented Oct 21, 2019

Excellent! Then I'm taking an "executive decision" and closing this.

@impaktor impaktor closed this Oct 21, 2019
@fluffyfreak

This comment has been minimized.

Copy link
Contributor

@fluffyfreak fluffyfreak commented Oct 21, 2019

I'm afraid the problem has been misunderstood, he means that when using the external camera when docked that it can clip through the station geometry.

The typical solution to this is to constrain the camera movement so that it cannot pass through solid objects using the physics/collision system/raycasting.

It's not that you can move the camera nearer or further, but that the clipping is possible at all which is the "bug".

Most games do prevent camera clipping nowadays, we've just never bothered yet.

@fluffyfreak fluffyfreak reopened this Oct 21, 2019
@fluffyfreak fluffyfreak changed the title 3d renderengine: external view misposioned when docked External view clips into station geometry when docked Oct 21, 2019
@impaktor

This comment has been minimized.

Copy link
Member

@impaktor impaktor commented Nov 13, 2019

@fluffyfreak so one should not be able to get an external view of a station if zooming out with the external camera when docked inside it?

For me it's a "bug vs. feature" question, but if someone wants to fix this, that's fine by me.

I guess the question is: is the external camera there for taking glory-shots of your craft/surrounding, and not part of the game-lore, or is it some "high tech drone" that is following the ship and giving the player an edge during e.g. combat?

@nozmajner

This comment has been minimized.

Copy link
Contributor

@nozmajner nozmajner commented Nov 13, 2019

I think the drone approach would detract from the game in the end.
It never bothered me that it can clip trough stuff, since for me it was never an immersive feature.
A possible fix could be that the default position would be at a given max distance in case you are docked in a certain sized dock, and above your ship a bit. That would avoid most of this problem I think.

@Cyborgscode

This comment has been minimized.

Copy link
Author

@Cyborgscode Cyborgscode commented Nov 13, 2019

Just remember, that the camera view was "outside" and force it to be "front" when docked to a station. After launch, it resets back to normal. Problem solved.

@impaktor

This comment has been minimized.

Copy link
Member

@impaktor impaktor commented Nov 13, 2019

After launch, it resets back to normal. Problem solved.

If that a problem even be...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.