Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when Load Game dialogue selected after New Game started #4720

Open
craigo- opened this issue Oct 17, 2019 · 1 comment

Comments

@craigo-
Copy link
Contributor

@craigo- craigo- commented Oct 17, 2019

Observed behaviour

Crash to desktop when you are in the Load dialogue and you select one of the Start on buttons, but continue to try to load a game.

Expected behaviour

That the game does not CTD. Probably the best way to deal with this is to not continue to present the initial buttons when presenting the 'Load' dialogue (as it was in the old UI in version 20180203).

Steps to reproduce

  1. Start game, with save games present

  2. Click Load game

  3. Click Start on Mars (you probably shouldn't be able to do this):
    image

  4. The game starts, but the 'Load game' dialogue persists. Select a saved game and click Load:
    image

  5. The game crashes to desktop with the following guru meditation error:
    image

NB: clicking the Cancel button at Step 4 works fine.

My pioneer version (and OS):
Pioneer: master (3dff8ca), approx. 20191017, Release x64
Windows 10 Enterprise 1809 x64

NB: a very similar guru meditation error happens with Pioneer 20190203. You cannot reproduce the error in Pioneer 20180203, because the Start on buttons are not there when the Load dialogue is present.

@Web-eWorks

This comment has been minimized.

Copy link
Member

@Web-eWorks Web-eWorks commented Oct 17, 2019

Ah, we just need to make the Load Game dialogue a modal. Pinging @vakhoir; this should theoretically be an easy fix. (If I need to expose Modal to pigui, just let me know.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.