Added shortcut icon #1166

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@Skodyn

Skodyn commented Apr 8, 2012

Added a desktop shortcut icon, hope you like it my first contribution

not sure how to reference the issue this refers to as below

Issue #1159 Windows desktop shortcut icon

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 8, 2012

Contributor

@robn: Tiny warning! Duplicate job (this one: 2e94fc6, and 11d0ffa in #1134).

Contributor

Sukender commented Apr 8, 2012

@robn: Tiny warning! Duplicate job (this one: 2e94fc6, and 11d0ffa in #1134).

@Brianetta

This comment has been minimized.

Show comment
Hide comment
@Brianetta

Brianetta Apr 10, 2012

Contributor

@Sukender This is why we prefer each pull request to fix one issue at a time.

Contributor

Brianetta commented Apr 10, 2012

@Sukender This is why we prefer each pull request to fix one issue at a time.

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 10, 2012

Contributor

@Brianetta: Sure. But now it's made, I had to draw attention on it :)

Contributor

Sukender commented Apr 10, 2012

@Brianetta: Sure. But now it's made, I had to draw attention on it :)

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 10, 2012

I'm happy if you close this one, it was only my first and I'm still learning :)

Skodyn commented Apr 10, 2012

I'm happy if you close this one, it was only my first and I'm still learning :)

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 10, 2012

Contributor

First or not, the important is the result, don't you think? Let's open those icons and compare!
Correct me if I'm wrong, but it seems your icon is 128x128x24bits. The one of 11d0ffa contains a set of images at different resolutions (6 images, from 256 to 16 pixels large, 3 of them are 24 bits, the 3 others are 8 bits). It's larger, but lets system choose appropriate size when needed. And if you ask, yes, Windows finds it difficult resizing an image...

Contributor

Sukender commented Apr 10, 2012

First or not, the important is the result, don't you think? Let's open those icons and compare!
Correct me if I'm wrong, but it seems your icon is 128x128x24bits. The one of 11d0ffa contains a set of images at different resolutions (6 images, from 256 to 16 pixels large, 3 of them are 24 bits, the 3 others are 8 bits). It's larger, but lets system choose appropriate size when needed. And if you ask, yes, Windows finds it difficult resizing an image...

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

I see what you mean, I created mine using IrfanView, I just simply re-sized the badge and converted it to .ico. I'm no expert but I find Irfanview is a great image editor. When I opened both in Irfanview this one on zooming in was crystal clear and sharp but when I opened 11d0ffa and zoomed in it looked quite blurred. I'm no coder and just learning to do how to do some things, so thanks. And yes windows can be a pain with lots of things, I spend many hours sometimes trying to solve things windows makes difficult. :)

Saying that, when they are sitting on the desktop 11d0ffa looks better as you can still read the word pioneer on the side, on this one the word looks broken up, plus this one has black corners, looks better as a circle without the corners.

Skodyn commented Apr 11, 2012

I see what you mean, I created mine using IrfanView, I just simply re-sized the badge and converted it to .ico. I'm no expert but I find Irfanview is a great image editor. When I opened both in Irfanview this one on zooming in was crystal clear and sharp but when I opened 11d0ffa and zoomed in it looked quite blurred. I'm no coder and just learning to do how to do some things, so thanks. And yes windows can be a pain with lots of things, I spend many hours sometimes trying to solve things windows makes difficult. :)

Saying that, when they are sitting on the desktop 11d0ffa looks better as you can still read the word pioneer on the side, on this one the word looks broken up, plus this one has black corners, looks better as a circle without the corners.

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 11, 2012

Contributor

AFAIK, IrfanView is more a viewer/manager than an editor (such as XNView, FastStone Viewer...), but yes it's nice. Still AFAIK, these viewers only display one image among the images set in a .ico (the default size, generally the closest to 32x32), hence the blur you experienced. On the desktop however, Windows uses the more appropriate size/depth it can find in the .ico file.

FYI, I personally use GIMP (raster images) and Inkscape (vector images) as editors, as they are both free. However the icon has been created using a specific tool, besides FastStone for resizing.

Contributor

Sukender commented Apr 11, 2012

AFAIK, IrfanView is more a viewer/manager than an editor (such as XNView, FastStone Viewer...), but yes it's nice. Still AFAIK, these viewers only display one image among the images set in a .ico (the default size, generally the closest to 32x32), hence the blur you experienced. On the desktop however, Windows uses the more appropriate size/depth it can find in the .ico file.

FYI, I personally use GIMP (raster images) and Inkscape (vector images) as editors, as they are both free. However the icon has been created using a specific tool, besides FastStone for resizing.

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 11, 2012

Contributor

I managed to make low-res icons have a better look (well my opinion!), by creating drawings from the original svg:
Pioneer 16x16 (16x16)
Pioneer 24x24 (24x24)
Pioneer 32x32 (32x32)
Pioneer 48x48 (48x48)

And the original icon:
Pioneer icon

You can download individual files at http://sukender.free.fr/pioneer/ (SVG are included).

@Luomu: Are you the author of the original one?

Please tell me if you find these low-res variants okay. If so, I may overwrite those in 11d0ffa (well, after optimizing the PNGs).

Contributor

Sukender commented Apr 11, 2012

I managed to make low-res icons have a better look (well my opinion!), by creating drawings from the original svg:
Pioneer 16x16 (16x16)
Pioneer 24x24 (24x24)
Pioneer 32x32 (32x32)
Pioneer 48x48 (48x48)

And the original icon:
Pioneer icon

You can download individual files at http://sukender.free.fr/pioneer/ (SVG are included).

@Luomu: Are you the author of the original one?

Please tell me if you find these low-res variants okay. If so, I may overwrite those in 11d0ffa (well, after optimizing the PNGs).

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

It keeps the text in shape, so I would agree they look better as far as keeping the text in shape is concerned (icons don't normally have text in them) the star in 11d0ffa looks blurred. Given the choice I would agree that 11d0ffa looks better as a whole when sitting on the desktop doing it's job as an icon, because the text keeps it's shape :)

However I think due to the text it's going to look different depending on which OS and desktop resolution your using. I'm using 1280x768 on windows xp, Using a different OS and res, it's most likely going to change the appearance of the icon (especially the text).

Skodyn commented Apr 11, 2012

It keeps the text in shape, so I would agree they look better as far as keeping the text in shape is concerned (icons don't normally have text in them) the star in 11d0ffa looks blurred. Given the choice I would agree that 11d0ffa looks better as a whole when sitting on the desktop doing it's job as an icon, because the text keeps it's shape :)

However I think due to the text it's going to look different depending on which OS and desktop resolution your using. I'm using 1280x768 on windows xp, Using a different OS and res, it's most likely going to change the appearance of the icon (especially the text).

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 11, 2012

Contributor

Err... I'm not sure to understand what you mean... Do you prefer the 11d0ffa (scaling the original badge at different resolutions), or the one in my previous post (the lower the resolution, the simpler the image)? Please note that the latter set of images will look the same on your desktop.

Contributor

Sukender commented Apr 11, 2012

Err... I'm not sure to understand what you mean... Do you prefer the 11d0ffa (scaling the original badge at different resolutions), or the one in my previous post (the lower the resolution, the simpler the image)? Please note that the latter set of images will look the same on your desktop.

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

Sorry, yes I was referring to 11d0ffa I've not had a chance to try the latter (the lower the res, the simpler the image).

Just had a good look and (48x48) (from your previous post, lower res simpler image) looks good (the text is clearer), but in my opinion 11d0ffa still looks the better overall.

Skodyn commented Apr 11, 2012

Sorry, yes I was referring to 11d0ffa I've not had a chance to try the latter (the lower the res, the simpler the image).

Just had a good look and (48x48) (from your previous post, lower res simpler image) looks good (the text is clearer), but in my opinion 11d0ffa still looks the better overall.

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 11, 2012

Contributor

Really? Well, I'm surprised. I really thought it would be better. Can you try the ".ico" file please? It's made from the last set of icons, and explorer should show it well. Please compare with 11d0ffa.

Contributor

Sukender commented Apr 11, 2012

Really? Well, I'm surprised. I really thought it would be better. Can you try the ".ico" file please? It's made from the last set of icons, and explorer should show it well. Please compare with 11d0ffa.

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

Ok, just need a bit of time. I was surprised too, but I think it's windows that messes with things no matter what they look like in a viewer they never come out the same when you put them on the desktop.

Skodyn commented Apr 11, 2012

Ok, just need a bit of time. I was surprised too, but I think it's windows that messes with things no matter what they look like in a viewer they never come out the same when you put them on the desktop.

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

Here's a screenshot showing all 4 on my desktop (except the one in this pull request)

pioneer.ico - is 11d0ffa , pioneer2.ico - is the 32x32, pioneer3.ico - is the 48x48 and pioneer4.ico - is the ".ico" file (in your last post).

Skodyn commented Apr 11, 2012

Here's a screenshot showing all 4 on my desktop (except the one in this pull request)

pioneer.ico - is 11d0ffa , pioneer2.ico - is the 32x32, pioneer3.ico - is the 48x48 and pioneer4.ico - is the ".ico" file (in your last post).

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 11, 2012

Contributor

Ah, I understand: you have "small" icons on your desktop, so it uses 32x32 version by default. When I do it on my desktop (configured with "big" icons by default under Win7), the 48x48 version shows up. Well, the thing could be to simply redo the 32x32 version, or accept that "small" icons are this way... What do you prefer?

Contributor

Sukender commented Apr 11, 2012

Ah, I understand: you have "small" icons on your desktop, so it uses 32x32 version by default. When I do it on my desktop (configured with "big" icons by default under Win7), the 48x48 version shows up. Well, the thing could be to simply redo the 32x32 version, or accept that "small" icons are this way... What do you prefer?

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 11, 2012

Well I only have xp to play with so I can only say for me as it looks on my desktop I prefer 11d0ffa

Skodyn commented Apr 11, 2012

Well I only have xp to play with so I can only say for me as it looks on my desktop I prefer 11d0ffa

@Luomu

This comment has been minimized.

Show comment
Hide comment
@Luomu

Luomu Apr 11, 2012

Member

@Luomu: Are you the author of the original one?

Yes the original is mine. It was meant to be printed of a coffee mug/t-shirt/underwear so it's not really perfect for tiny icon use.
Your modifications look okay, although it's not really necessary to keep the text (it looks a bit like "Piobeer" anyway).

Member

Luomu commented Apr 11, 2012

@Luomu: Are you the author of the original one?

Yes the original is mine. It was meant to be printed of a coffee mug/t-shirt/underwear so it's not really perfect for tiny icon use.
Your modifications look okay, although it's not really necessary to keep the text (it looks a bit like "Piobeer" anyway).

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 12, 2012

@Luomu I would agree about the text, don't think it's absolutely necessary in the icon

Skodyn commented Apr 12, 2012

@Luomu I would agree about the text, don't think it's absolutely necessary in the icon

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 12, 2012

Contributor

Understood, guys! Here are 4 versions of the 32x32 image:
Pioneer 32x32 v0 (original resized)
Pioneer 32x32 v2 (text more visible)
Pioneer 32x32 v1 (made planet smaller)
Pioneer 32x32 v3 (removed text)
My preference goes to the last one, as you. And you?

I suggest we keep the text on the 48px version, as it is readable. Don't you think?

@Luomu: "Piobeer"! Hahaha! Sounds like a "alcoholic simulator" :)

Contributor

Sukender commented Apr 12, 2012

Understood, guys! Here are 4 versions of the 32x32 image:
Pioneer 32x32 v0 (original resized)
Pioneer 32x32 v2 (text more visible)
Pioneer 32x32 v1 (made planet smaller)
Pioneer 32x32 v3 (removed text)
My preference goes to the last one, as you. And you?

I suggest we keep the text on the 48px version, as it is readable. Don't you think?

@Luomu: "Piobeer"! Hahaha! Sounds like a "alcoholic simulator" :)

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 12, 2012

I agree, my preference is the last (removed text), the "Piobeer's" are on me :)

Skodyn commented Apr 12, 2012

I agree, my preference is the last (removed text), the "Piobeer's" are on me :)

@Luomu

This comment has been minimized.

Show comment
Hide comment
@Luomu

Luomu Apr 16, 2012

Member

The last one is fine. I guess @Sukender can make a PR now.

If any hobbyist graphics designers are listening, I am still in favour of having a more "iconic" icon someday, something that works with less colours/better with variable sizes.

Member

Luomu commented Apr 16, 2012

The last one is fine. I guess @Sukender can make a PR now.

If any hobbyist graphics designers are listening, I am still in favour of having a more "iconic" icon someday, something that works with less colours/better with variable sizes.

@Sukender

This comment has been minimized.

Show comment
Hide comment
@Sukender

Sukender Apr 19, 2012

Contributor

Sure for the PR. But I'll wait for the CMake PR, as there are icons added there (I'll replace them).

About designer's work, I agree, and this makes me think about saving original SVGs into Git repo, as source code is. May I create a "/dataWork" dir for this?

Contributor

Sukender commented Apr 19, 2012

Sure for the PR. But I'll wait for the CMake PR, as there are icons added there (I'll replace them).

About designer's work, I agree, and this makes me think about saving original SVGs into Git repo, as source code is. May I create a "/dataWork" dir for this?

@Skodyn

This comment has been minimized.

Show comment
Hide comment
@Skodyn

Skodyn Apr 19, 2012

@Sukender am I ok to close this pull request now?

Skodyn commented Apr 19, 2012

@Sukender am I ok to close this pull request now?

@robn

This comment has been minimized.

Show comment
Hide comment
@robn

robn Apr 19, 2012

Member

Leave it open. I will treat this as the canonical issue about the Windows icon, and ignore the relevant commits in #1134 for now.

Member

robn commented Apr 19, 2012

Leave it open. I will treat this as the canonical issue about the Windows icon, and ignore the relevant commits in #1134 for now.

@robn

This comment has been minimized.

Show comment
Hide comment
@robn

robn Jul 29, 2012

Member

For my own reference, how to include an icon in the mingw executable:

http://stackoverflow.com/questions/708238/how-do-i-add-an-icon-to-a-mingw-gcc-compiled-executable

Member

robn commented Jul 29, 2012

For my own reference, how to include an icon in the mingw executable:

http://stackoverflow.com/questions/708238/how-do-i-add-an-icon-to-a-mingw-gcc-compiled-executable

@johnbartholomew johnbartholomew referenced this pull request Sep 23, 2012

Merged

Application icon #1537

@johnbartholomew

This comment has been minimized.

Show comment
Hide comment
@johnbartholomew

johnbartholomew Sep 29, 2012

Contributor

Done, finally (#1537).

Contributor

johnbartholomew commented Sep 29, 2012

Done, finally (#1537).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment