New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the FFE-alike Achernar system. #1452

Merged
merged 2 commits into from Sep 4, 2012

Conversation

Projects
None yet
4 participants
@fluffyfreak
Contributor

fluffyfreak commented Aug 22, 2012

This re-implements the Achernar star system so that it resembles the Achenar star system from Frontier & FFE. Submitting as a pull request so that people can double check my working and hopefully we can get this into Pioneer :)

It's a fairly interesting system, the world Capitol currently appears to have mountains +130km high all over it so I must have gotten something.... well wrong, but interestingly so!

Commit messages:

Firstly removed it (Achernar) from the 03_bright_stars.lua
Added a new custom system file called 04_empire.lua with the system definition.
Added an option to the game start menu to begin playing in the Achernar system on a starport on the world Conversion.
Finally added strings to the language files that I could by copy-pasting existing start point strings for Lave.

Add the FFE-alike Achernar system.
Firstly removed it from the 03_bright_stars.lua
Added a new custom system file called 04_empire.lua with the system definition.
Added an option to the game start menu to begin playing in the Achernar system on a starport on the world Conversion.
Finally added strings to the language files that I could by copy-pasting existing start point strings for Lave.
@Brianetta

This comment has been minimized.

Show comment
Hide comment
@Brianetta

Brianetta Aug 22, 2012

Contributor

The real Achernar system has some very interesting characteristics which we should try to implement at some point. The primary is the most oblate known star in the galaxy, due to its high angular velocity. So much so, that it's more than half again as fat at the equator as it is from pole to pole. It's practically Smartie-shaped.

It's also very, very bright, of course.

Contributor

Brianetta commented Aug 22, 2012

The real Achernar system has some very interesting characteristics which we should try to implement at some point. The primary is the most oblate known star in the galaxy, due to its high angular velocity. So much so, that it's more than half again as fat at the equator as it is from pole to pole. It's practically Smartie-shaped.

It's also very, very bright, of course.

@Brianetta

This comment has been minimized.

Show comment
Hide comment
@Brianetta

Brianetta Aug 22, 2012

Contributor

Also, since Frontier was released, the VLT discovered Achernar's companion star. It doens't normally show up against Achernar's brightness, but the companion star is about as bright as Sirius (alpha) and very much brighter than Sol.

http://stardate.org/radio/program/2009-02-06

Don't know which is more important, in this case - writing out a real star, or trying to be close to Frontier.

Contributor

Brianetta commented Aug 22, 2012

Also, since Frontier was released, the VLT discovered Achernar's companion star. It doens't normally show up against Achernar's brightness, but the companion star is about as bright as Sirius (alpha) and very much brighter than Sol.

http://stardate.org/radio/program/2009-02-06

Don't know which is more important, in this case - writing out a real star, or trying to be close to Frontier.

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Aug 22, 2012

Contributor

In this case I've done it so that it's deliberately closer to FFE/Frontier, but there's no reason why we shouldn't change it to match the real star either now with this commit - though I'll need some help with that - or later once it's in.

Also a Smartie shaped star would be amazing :D we'd have people submitting bug reports about it's shape!

Contributor

fluffyfreak commented Aug 22, 2012

In this case I've done it so that it's deliberately closer to FFE/Frontier, but there's no reason why we shouldn't change it to match the real star either now with this commit - though I'll need some help with that - or later once it's in.

Also a Smartie shaped star would be amazing :D we'd have people submitting bug reports about it's shape!

@Ae-2222

This comment has been minimized.

Show comment
Hide comment
@Ae-2222

Ae-2222 Aug 24, 2012

Contributor

As we were discussing on IRC earlier it's eminently possible to depict equatorial bulges due to fast rotation through the terrain code. The result of this flattening is an ellipsoid (oblate spheroid - i.e. an elliptical cross-section in the plane containing the two poles, planet center, and two equator points).

This is the new terrain code with an equatorial to polar radius ratio of 1.56 (@fluffyfreak: I really should have mentioned here I was working on this before I started, to check you weren't already implementing it and prevent duplicated effort, but it's reasonably trivial and I forgot you were not on IRC:) ) :

This shows sol, but the principle is the same for other stars.

This is sol with a much higher ratio:

Contributor

Ae-2222 commented Aug 24, 2012

As we were discussing on IRC earlier it's eminently possible to depict equatorial bulges due to fast rotation through the terrain code. The result of this flattening is an ellipsoid (oblate spheroid - i.e. an elliptical cross-section in the plane containing the two poles, planet center, and two equator points).

This is the new terrain code with an equatorial to polar radius ratio of 1.56 (@fluffyfreak: I really should have mentioned here I was working on this before I started, to check you weren't already implementing it and prevent duplicated effort, but it's reasonably trivial and I forgot you were not on IRC:) ) :

This shows sol, but the principle is the same for other stars.

This is sol with a much higher ratio:

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Sep 2, 2012

Contributor

So is there any reason not to put this in?
I only wonder because sometimes pull requests like this sit here seemingly forever without any clear indication why they haven't accepted or rejected.

Contributor

fluffyfreak commented Sep 2, 2012

So is there any reason not to put this in?
I only wonder because sometimes pull requests like this sit here seemingly forever without any clear indication why they haven't accepted or rejected.

@johnbartholomew

This comment has been minimized.

Show comment
Hide comment
@johnbartholomew

johnbartholomew Sep 2, 2012

Contributor

Ok, from Luomu, robn and myself:

Yes to the system, but to avoid a proliferation of start points, could you make the Achernar start replace the Eridani start?

Contributor

johnbartholomew commented Sep 2, 2012

Ok, from Luomu, robn and myself:

Yes to the system, but to avoid a proliferation of start points, could you make the Achernar start replace the Eridani start?

@Ae-2222

This comment has been minimized.

Show comment
Hide comment
@Ae-2222

Ae-2222 Sep 2, 2012

Contributor

but there's no reason why we shouldn't change it to match the real star either now with this commit - though I'll need some help with that - or later once it's in.

If no one has objections I'll look at adding the real star data in 1459, or later, after this is merged. I'm sure Braben would have appreciated the extra accuracy as he wanted real stars in the first place:)

The smartie shape will be definitely incorporated as part of 1459, of course:)

Contributor

Ae-2222 commented Sep 2, 2012

but there's no reason why we shouldn't change it to match the real star either now with this commit - though I'll need some help with that - or later once it's in.

If no one has objections I'll look at adding the real star data in 1459, or later, after this is merged. I'm sure Braben would have appreciated the extra accuracy as he wanted real stars in the first place:)

The smartie shape will be definitely incorporated as part of 1459, of course:)

@johnbartholomew

This comment has been minimized.

Show comment
Hide comment
@johnbartholomew

johnbartholomew Sep 2, 2012

Contributor

If no one has objections I'll look at adding the real star data in 1459, or later, after this is merged.

Sounds good to me.

Contributor

johnbartholomew commented Sep 2, 2012

If no one has objections I'll look at adding the real star data in 1459, or later, after this is merged.

Sounds good to me.

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Sep 3, 2012

Contributor

@johnbartholomew
RE: the start point change, yeah I can do that. Also found an image of the start menu from Frontier, it only had Ross 154, Mars and Lave as start positions!

Makes we wonder if I shouldn't just remove it from the start menu entirely, any strong feelings either way amongst you guys?

Contributor

fluffyfreak commented Sep 3, 2012

@johnbartholomew
RE: the start point change, yeah I can do that. Also found an image of the start menu from Frontier, it only had Ross 154, Mars and Lave as start positions!

Makes we wonder if I shouldn't just remove it from the start menu entirely, any strong feelings either way amongst you guys?

@Brianetta

This comment has been minimized.

Show comment
Hide comment
@Brianetta

Brianetta Sep 3, 2012

Contributor

One thing I liked about Frontier was that going to work for the Empire always meant defecting from some other area. It had to be an in-game choice, rather than an untried start position.

Contributor

Brianetta commented Sep 3, 2012

One thing I liked about Frontier was that going to work for the Empire always meant defecting from some other area. It had to be an in-game choice, rather than an untried start position.

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Sep 3, 2012

Contributor

@Brianetta Ok that makes sense, I'll change it to remove the Achernar start position. I only really added it to make my life easier whilst I was developing and thought I'd keep it in when I made the pull request :)

Contributor

fluffyfreak commented Sep 3, 2012

@Brianetta Ok that makes sense, I'll change it to remove the Achernar start position. I only really added it to make my life easier whilst I was developing and thought I'd keep it in when I made the pull request :)

@fluffyfreak

This comment has been minimized.

Show comment
Hide comment
@fluffyfreak

fluffyfreak Sep 3, 2012

Contributor

Ok that change is made, the Imperial option is no longer on the start menu so people will have to decide to go and visit Achernar :)

Contributor

fluffyfreak commented Sep 3, 2012

Ok that change is made, the Imperial option is no longer on the start menu so people will have to decide to go and visit Achernar :)

@johnbartholomew johnbartholomew merged commit 2efc1a3 into pioneerspacesim:master Sep 4, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment