Switch font texture U/V coordinates to unsigned int #3273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes build with freetype 2.5.4, in which FT_Bitmap::rows, FT_Bitmap::width types were changed from int to unsigned int. Because of that, max(int, unsigned int) failed to compile. And since U/V coordinates are essentially unsigned, this also improves code consistency.
|
Excellent. I just found this problem on my cross-compilation environment with the latest build MXE. |
|
Hi @AMDmi3 sorry we haven't had time to look at this yet I'll try to review it in the next couple of days! |
|
No problem, thanks! |
|
This looks fine, what would you like to be known as in the |
|
I'm fine with either. Since most people are listed by real names, 'Dmitry Marakasov' would seem natural. |
fluffyfreak
added a commit
that referenced
this pull request
Dec 18, 2014
Switch font texture U/V coordinates to unsigned int
|
Merged and welcome to the AUTHORS list :) |
|
Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes build with freetype 2.5.4, in which FT_Bitmap::rows,
FT_Bitmap::width types were changed from int to unsigned int. Because
of that, max(int, unsigned int) failed to compile. And since U/V
coordinates are essentially unsigned, this also improves code
consistency.