Do not spawn unarmed pirates #3903

Merged
merged 1 commit into from Jan 11, 2017

Projects

None yet

3 participants

@robothauler
Contributor

Closes #3902
I did not touch the police pumpkinseed. Some say it could be a corrupt police officer or it's a stolen police craft.

@impaktor
Member
impaktor commented Jan 8, 2017

This looks OK.

I did not touch the police pumpkinseed.

I'd like to know how that happens, so to me that's a bug, (although I'm not sure I even understand the description of the bug, as you saw in that issue). A fix for that bug should be a separate commit, (or PR), assuming you can track it down.

@robothauler
Contributor

For example:
return def.tag == 'SHIP' and def.hyperdriveClass > 0 and def.hullMass <= 150
does not preclude the police pumpkinseed because it has hyperdrive.
Maybe a 'def.price > 0' can preclude all special ships.

@nozmajner
Contributor

What if there would be a tag in each ship.json, that would make it available or unavailable for pirates? Like how the static ships are handled.

@robothauler
Contributor

Something like
"role" : {"pirate", "merchant", ...}

@nozmajner
Contributor

Hmm, a role field could be handy in the future for other stuff for sure.

@impaktor
Member
impaktor commented Jan 8, 2017

Wait, are you talking about the fact that pumpkinseed ins't exclusivley reserved for police? Because, neither is kanara, right? So I don't considet that a bug. Pirates should be able to fly pumpkinseed and kanara, if those ships fulfils the filter conditions.

@impaktor impaktor merged commit a825e67 into pioneerspacesim:master Jan 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@robothauler robothauler deleted the robothauler:pirates branch Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment