New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further extend soundtrack #4491

Merged
merged 1 commit into from Nov 21, 2018

Conversation

Projects
None yet
5 participants
@WKFO
Contributor

WKFO commented Nov 4, 2018

If there is a better way to accomplish what I did in data/modules/MusicPlayer.lua at line 158, let me know. Because I don't want to break anything.

Basically I don't want music to change whenever a ship comes by a starport while you are docked.

@WKFO

This comment has been minimized.

Contributor

WKFO commented Nov 5, 2018

It would be nice if we had music modules for some mission types, which would override the default player. For example when the player finds the broken ship in a SAR mission, we don't need to play a suspenseful track (the player knows that the ship is not hostile); but in most other encounters we do need to play it (because most deep-space encounters are hostile).

@Web-eWorks

This comment has been minimized.

Contributor

Web-eWorks commented Nov 5, 2018

@WKFO The Ship class provides IsDocked(), which will just give you a straight boolean. Also, you don't need to explicitly test for nil - nil is by default a "false" value. You can just rewrite that change to:

if alert == "SHIP_NEARBY" and not ship:IsDocked() then
@laarmen

This comment has been minimized.

Contributor

laarmen commented Nov 14, 2018

@WKFO Do you still have the source files for all the tracks you made for Pioneer ? If so, would you be willing to share them, and how big are they ?

@WKFO

This comment has been minimized.

Contributor

WKFO commented Nov 14, 2018

@laarmen No, but I think I still have some good portion of them. I would be willing to share most of what's left, but size depends on the format because I don't use the same production method for every track.

I can share them as FL Studio (Windows x64) projects but I suspect that they heavily rely on the setup on my computer in order to work properly.

Alternatively, I can convert them all to MIDI files but that would lose all of the synthesizer modules.

Some of the instruments were played by hand so they don't have source files at all.

@WKFO WKFO changed the title from WIP - Further extend soundtrack to Further extend soundtrack Nov 18, 2018

@fluffyfreak

This comment has been minimized.

Contributor

fluffyfreak commented Nov 20, 2018

Ok, this PR looks good to merge for me.
Is there anything else you want to add @WKFO ?

@impaktor

This comment has been minimized.

Member

impaktor commented Nov 20, 2018

(ideally the "code improvement" commit aught to be squashed into the first)

@WKFO

This comment has been minimized.

Contributor

WKFO commented Nov 20, 2018

I can just rebase everything into a single commit when I get home.

@WKFO WKFO force-pushed the WKFO:ost branch from ad99757 to 712e54c Nov 20, 2018

@WKFO

This comment has been minimized.

Contributor

WKFO commented Nov 20, 2018

@fluffyfreak No, that's all, there is nothing else I've planned to do.
I squashed everything into a single commit for convenience.

@impaktor impaktor merged commit 3eb4b44 into pioneerspacesim:master Nov 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@WKFO WKFO deleted the WKFO:ost branch Nov 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment