New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-format all the things! #4508

Merged
merged 1 commit into from Jan 6, 2019

Conversation

Projects
None yet
2 participants
@Web-eWorks
Copy link
Contributor

Web-eWorks commented Jan 2, 2019

(Finally) Apply clang-format to the entire code base. Will likely need another pass to resolve hidden dependency errors (and as such the build will likely fail), but the first bit is done.

CC @impaktor: I'll get the clang-format stuff, you just handle updating the names and dates in your PR.

Now without Autotools files getting messed up!

Closes #4445.

@Web-eWorks

This comment has been minimized.

Copy link
Contributor

Web-eWorks commented Jan 2, 2019

@impaktor This PR has passed all tests. Modelcompiler is still broken, but everything compiles normally. Ready to merge when you are.

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Jan 3, 2019

All checks still fail...

So we're happy with this format, and the pointer alignment to be "right"?

ping C++-ers: @fluffyfreak, @ecraven, @johnbartholomew

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Jan 3, 2019

Also, since we're no longer touching all the files in the same PR as in the "happy new year" #4507, this needs rebasing.

@Web-eWorks Web-eWorks force-pushed the Web-eWorks:clang-formattening branch 2 times, most recently from 661a11a to 8700fd2 Jan 3, 2019

@Web-eWorks

This comment has been minimized.

Copy link
Contributor

Web-eWorks commented Jan 3, 2019

Rebased, and with #4509, error free. Ready for merge at your discretion, @impaktor.

EDIT: rebased onto latest master so we can get a clean, error-free build.

@Web-eWorks Web-eWorks force-pushed the Web-eWorks:clang-formattening branch 3 times, most recently from b842673 to 1a95b95 Jan 4, 2019

Run clang-format over the entire code base.
Fix hidden header-inclusion-order dependency errors.
Update .clang-format for v7.0.1.

@Web-eWorks Web-eWorks force-pushed the Web-eWorks:clang-formattening branch from 1a95b95 to 5cdaefa Jan 5, 2019

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Jan 6, 2019

Does anyone have any objections to this PR that will molest the entire C++ code base? If not, I suggest we merge soonish.

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Jan 6, 2019

We really need to very clearly propagate the information of code formating to the wiki, and how to set up pre-commit hook in git, or else, all new PRs will be borked.

EDIT once this is merged, that is.

@impaktor impaktor merged commit 5cdaefa into pioneerspacesim:master Jan 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Jan 6, 2019

There are a bunch of warnings, unused variables, and such, I guess that could be fixed in the future.

Now we all need to add the git commit hook thingy, so a wiki on that would be great.

@Web-eWorks

This comment has been minimized.

Copy link
Contributor

Web-eWorks commented Jan 6, 2019

Will get that up in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment