New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System info from c++ to lua. Add setting. #4528

Merged
merged 4 commits into from Feb 8, 2019

Conversation

Projects
None yet
3 participants
@ecraven
Copy link
Contributor

ecraven commented Feb 6, 2019

Move the screenshot information (body, system, path) shown in the upper left corner after hitting TAB several times from lua. Add a setting to the settings window.

@ecraven

This comment has been minimized.

Copy link
Contributor Author

ecraven commented Feb 6, 2019

Old:
old

New:
new

Setting:
setting

"DISABLE_SCREENSHOT_INFO_DESC": {
"description": "",
"message": "Check this to show nothing, not even System information, in screenshot mode (toggle HUD mode)."
},

This comment has been minimized.

@impaktor

impaktor Feb 7, 2019

Member

Nitpick, but not sure I like the "Check this to " part. A bit redundant.

Instead maybe have:

"When in screenshot mode (toggle HUD mode), hide all displayed info, including System information"

or

"Hide all displayed info, including system coordinates, when in screenshot mode (toggle HUD mode)"

Or a combination of the two. Or neither. Up to you.

@impaktor

This comment has been minimized.

Copy link
Member

impaktor commented Feb 8, 2019

Also, changelog changes is usually not in the PR, but bundled in the merge commit at merge time

@ecraven ecraven force-pushed the ecraven:system-info-in-lua branch from ae6314f to 1db4276 Feb 8, 2019

@ecraven

This comment has been minimized.

Copy link
Contributor Author

ecraven commented Feb 8, 2019

changed translation, removed changelog.

@impaktor impaktor merged commit 1db4276 into pioneerspacesim:master Feb 8, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment