Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions on building pioneer with CMake and MSYS2 #4535

Merged
merged 1 commit into from Mar 7, 2019

Conversation

Projects
None yet
4 participants
@dlshcbmuipmam
Copy link
Contributor

commented Feb 11, 2019

The documentation lacks the instruction of CMake build in Windows, but it is strict forward to do so in MSYS2. I have added a few lines to describe that.

@impaktor

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Nice, thanks!

@pcercuei

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

What's about the CMAKE_SH trick? I never had to do that.

@dlshcbmuipmam

This comment has been minimized.

Copy link
Contributor Author

commented Feb 11, 2019

What's about the CMAKE_SH trick? I never had to do that.

This is a strange limitation of CMake and MSYS2. There is a sh.exe under MSYS2 path, and you will get an error because of that when you run CMake in MinGW shell. "CMAKE_SH="CMA KE_SH-NOTFOUND" tells CMake to ignore the sh.exe.

@fluffyfreak fluffyfreak merged commit 75bd26a into pioneerspacesim:master Mar 7, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@fluffyfreak

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

I don't know why this hadn't already been merged so I've done it now :)

Thanks for the instructions @dlshcbmuipmam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.