Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sound code to it's own folder, delete Pi::BoinkNoise. #4557

Merged
merged 1 commit into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@Web-eWorks
Copy link
Contributor

commented Mar 10, 2019

Pi::BoinkNoise is dead! Long live pigui.playBoinkNoise!
Continuing my recent PRs, this moves the sound-related code into it's own source folder to cut down on the top-level src/ bloat, and deletes the abomination formerly known as Pi::BoinkNoise(). Only one instance of the underlying call to Sound::PlaySfx() remains in C++ source code, but this time it's actually worth keeping as it's being driven by user input.

There's a new function in the pigui / ui Lua namespace, ui.playBoinkNoise(). This is where the functionality should have been at the start, instead of the top-level engine namespace.

EDIT: also removed the unused function WorldView::OnClickBlastoff(), which apparently was sticking around from a previous round of refactoring.

@impaktor

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

Looks like there isn't much to object to here, so assuming @fluffyfreak or anyone else is fine with this, I suggest we merge this soonish (one day/now?)

@fluffyfreak

This comment has been minimized.

Copy link
Contributor

commented Mar 19, 2019

Stuffs moved so I might have to fixup the vs projects but that's on me so merging now.

@fluffyfreak fluffyfreak merged commit 312ad5a into pioneerspacesim:master Mar 19, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.