New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement map view music, improve music selection, add tracks #5093
Conversation
A few new changes:
|
Also using this opportunity to add another track. |
I would add a track for thoose times that the player stays close or the player orbits a star |
I might look into something along those lines, but not for now. It would require some effort I can't provide soon enough. |
My initial reservations about a map music in unexplored space has been solved and I came to the conclusion that if there is a difference between world view and map view in populated space, there should be a distinction in unexplored space as well. |
I made a slight rearrangement; moved the old, more energetic unexplored map music to map-core, and instead added another, calmer track to map-unexplored. |
@WKFO any further changes you'd like to make to this PR, or is it ready for merge? Sorry it's taken so long to get around to merging again! |
@Web-eWorks I have nothing planned, it should be ready for merge if you don't see any problems. |
Implements map view music and adds a few tracks, just like the title suggests.
Map view music is triggered if the already playing track ends while the player is in a map view (sector or system), but fades out and switches back to ambient once player returns to world (flight) view. (This way it doesn't trigger for every short glance at the map, but it's supposed to be playing if you are taking your sweet time admiring the galaxy/plotting routes into hell).
map-core category plays if player is reasonably close to the populated area of the galaxy (starclock.ogg, it's sort of techno-electronica-whatever), map-unexplored plays while the player is far far away from civilization (no music, minimal ambient sounds to fit the feeling of the unexplored ambient tracks).
Finally, also adding 2 tracks to discovery category which I wanted to add for a while (I didn't think those two were worth a PR of their own, so I'm attaching them here.)