CMakeList and scan_enums update to python3 - #6217
Merged
Merged
Conversation
mwerle
approved these changes
Oct 5, 2025
mwerle
left a comment
mwerle
left a comment
Contributor
There was a problem hiding this comment.
Haven't tested specifically but code compiles and runs.
Apart from a minor nitpick LGTM.
Member
|
Looks like running it adds Geoshpere & Gunmanager related constants. |
impaktor
force-pushed
the
cmake-python3
branch
from
October 28, 2025 09:52
a84a390 to
bf49889
Compare
Member
|
Squashed, force-pushed & rebased to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to build Pioneer on the latest Raspberry Pi OS "Trixie" it ran into issues with the
scan_enums.pyrequiring Python2 which now appears to be so deprecated it cannot be recovered at all.So I've tried updating it to Python3 in both
CMakeLists.txtand thescan_enums.pyscript. This seems to work with only minimal changes and resolves the issues around Python2 deprecation. It successfully generates:I have not included those modified files here.