Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TURN is not implemented #215

Closed
superp00t opened this issue Nov 2, 2018 · 12 comments
Closed

TURN is not implemented #215

superp00t opened this issue Nov 2, 2018 · 12 comments

Comments

@superp00t
Copy link

superp00t commented Nov 2, 2018

var ICEcfg = webrtc.RTCConfiguration{
	IceTransportPolicy: webrtc.RTCIceTransportPolicyRelay,
	IceServers: []webrtc.RTCIceServer{
		{
			URLs: []string{"turn:bex.pg.ikrypto.club:3478"},
			Username: "cryptodog",
			Credential: "preventing-ip-leakage",
			CredentialType: webrtc.RTCIceCredentialTypePassword,
		},
	},
}

peerConnection, err := webrtc.New(ICEcfg)

This does not return an error but prints "turn is not implemented" in the terminal.

I would like to be able to use the pions TURN server with the pions/webrtc package, to prevent my true IP from being leaked to WebRTC peers.

@Sean-Der
Copy link
Member

Sean-Der commented Nov 2, 2018

Hey @superp00t sorry I haven't implemented TURN yet. I am currently working on DTLS (which is turning out much harder then I anticipated) but after I am done this is our next big roadmap item.

btw great avatar choice :) 'i have no mouth and i must scream' is fantastic.

@zsmweb
Copy link

zsmweb commented Dec 3, 2018

@Sean-Der Is there any plan to implement TURN? Is the DTLS can be used?

@Sean-Der
Copy link
Member

Sean-Der commented Dec 5, 2018

Hey @zsmweb

We probably will start TURN in ~3 weeks. With DTLS just being finished we need to pay back some tech debt. I will make sure to update this ticket when I have started.

thanks!

@backkem
Copy link
Member

backkem commented Dec 24, 2018

We should conciser adding TCP support when implementing this since it will likely affect very similar code paths.

@maxwelldergosits
Copy link

Hey has TURN implementation begun?

@backkem
Copy link
Member

backkem commented Feb 8, 2019

Hi @maxwelldergosits, the master branch now supports connecting to remote relayed (TURN) candidates. We've not yet started implementing support for creating local relayed candidates.

@HidenXL
Copy link

HidenXL commented Apr 27, 2019

hi, pion is great work, do you plan to complete this implementation?

@Sean-Der
Copy link
Member

Sean-Der commented May 1, 2019

Hey @HidenXL

We are working on some bugs that effect v2.0.0 when that lands I will start working on TURN! My rough estimate is around ~1 month.

thanks for using Pion :)

@Sean-Der
Copy link
Member

Hey everyone as an update me and @enobufs are taking this on, we are shooting for June 1st as the delivery date. Thanks for the patience!

@enobufs
Copy link
Member

enobufs commented May 22, 2019

@Sean-Der Please let me know if there's anything I can help!!

@Sean-Der
Copy link
Member

Thanks @enobufs

Thanks to @ernado this is going to be really easy :D he has already built a TURN client library. We are just going to bring it into Pion! So I think we might even be able to land this ahead of schedule

@Sean-Der
Copy link
Member

Good news! TURN has landed in master :)

There are lots of rough edges that need to be done (you can follow them here) they are all in Pion WebRTC's dependencies.

However! Pion WebRTC itself has completely stabilized re: TURN so closing this ticket.

thanks for using Pion, and I appreciate the patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants