Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix custom site for oauth #100

Merged
merged 2 commits into from Apr 1, 2013

Conversation

Projects
None yet
3 participants
Contributor

5long commented Mar 31, 2013

Hi, I've been using this Github client library and found it easy to work with. However, I've encountered this problem with authorization. The problem is demostrated by commit e201c7e and fixed in the later commit.

I admit that I'm breaking the current design a little bit. But I guess the Github::Client#client method should be private anyway and I believe my approach actually made it harder to misuse.

Feel free to tell me what more to do to get this patch merged so that I can remove some workaround from my app :)

Coverage decreased (-0.05%) when pulling 4b27063 on 5long:fix-custom-site-for-oauth into 76cd473 on peter-murach:master.

View Details

piotrmurach added a commit that referenced this pull request Apr 1, 2013

@piotrmurach piotrmurach merged commit 018aaa9 into piotrmurach:master Apr 1, 2013

1 check passed

default The Travis build passed
Details
Owner

piotrmurach commented Apr 1, 2013

Hi, this is a quality patch and I was more than happy to merge it in, even more so as this is the 100th issue:) I agree with your observation about making the client private. Thanks a lot, I've released v0.9.5 that includes your patch as well as some minor changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment