Implement listing and getting piped for web #159
Conversation
|
The following files are not gofmt-ed. By commenting pkg/app/api/service/webservice/model.go--- pkg/app/api/service/webservice/model.go.orig
+++ pkg/app/api/service/webservice/model.go
@@ -23,15 +23,15 @@
return nil
}
return &Piped{
- Id: input.Id,
- Desc: input.Desc,
- ProjectId: input.ProjectId,
- Version: input.Version,
- StartedAt: input.StartedAt,
+ Id: input.Id,
+ Desc: input.Desc,
+ ProjectId: input.ProjectId,
+ Version: input.Version,
+ StartedAt: input.StartedAt,
CloudProviders: input.CloudProviders,
- RepositoryIds: input.RepositoryIds,
- Disabled: input.Disabled,
- CreatedAt: input.CreatedAt,
- UpdatedAt: input.UpdatedAt,
+ RepositoryIds: input.RepositoryIds,
+ Disabled: input.Disabled,
+ CreatedAt: input.CreatedAt,
+ UpdatedAt: input.UpdatedAt,
}
}
|
| }, nil | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetPiped(ctx context.Context, req *webservice.GetPipedRequest) (*webservice.GetPipedResponse, error) { |
There was a problem hiding this comment.
ctx is unused in GetPiped
| }, nil | ||
| } | ||
|
|
||
| func (a *FakeWebAPI) GetPiped(ctx context.Context, req *webservice.GetPipedRequest) (*webservice.GetPipedResponse, error) { |
There was a problem hiding this comment.
req is unused in GetPiped
|
/golinter fmt |
| } | ||
|
|
||
| // OmittedPiped is the minimal message for listing on the web application. | ||
| message OmittedPiped { |
There was a problem hiding this comment.
Not sure about needing this. IMO just use Piped is fine.
And we can add ConnectionStatus field to the above Piped message too.
There was a problem hiding this comment.
About the size, I think we do not have a large number of piped for each project.
And we are also returning a list of larger models such as deployment, applications.
There was a problem hiding this comment.
That's good. My brain doesn't work in today 😇
|
Code coverage for golang is |
| "@org_golang_google_grpc//:go_default_library", | ||
| "@org_golang_google_protobuf//reflect/protoreflect:go_default_library", |
There was a problem hiding this comment.
Not sure why this is included?
I could not find where we are using this.
| @@ -92,9 +136,20 @@ message DisablePipedResponse { | |||
| } | |||
|
|
|||
| message ListPipedsRequest { | |||
| // Whether to include the status value in the response message. | |||
| bool withStatus = 1; | |||
|
Code coverage for golang is |
pkg/app/api/api/web_api.go
Outdated
| Disabled: pipeds[i].Disabled, | ||
| CreatedAt: pipeds[i].CreatedAt, | ||
| UpdatedAt: pipeds[i].UpdatedAt, | ||
| } |
There was a problem hiding this comment.
Now we can use webserivce.MakePiped function.
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. While reducing the number of query and get ping connection status from piped_statsThis was created by todo plugin since "TODO:" was found in 1854dad when #159 was merged. cc: @stormcat24. |
|
Thank you. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: