Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error for web mock utils #1978

Merged
merged 1 commit into from May 21, 2021
Merged

Fix type error for web mock utils #1978

merged 1 commit into from May 21, 2021

Conversation

cakecatz
Copy link
Contributor

@cakecatz cakecatz commented May 19, 2021 •
edited

What this PR does / why we need it:

Fix the following error.

Type 'Record<string, any> | undefined' is not assignable to type 'Uint8Array'.
  Type 'undefined' is not assignable to type 'Uint8Array'.

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested a review from nghialv May 19, 2021 11:54
@pipecd-bot pipecd-bot added size/S and removed size/XS labels May 20, 2021
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 33.51%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 85.66%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented May 20, 2021

/lgtm

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 718880c into master May 21, 2021
@pipecd-bot pipecd-bot deleted the fix-type-error branch May 21, 2021 02:18
This was referenced Jun 9, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved area/web lgtm release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cakecatz @pipecd-bot @nghialv @khanhtc1202