Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable onChain trigger by default #2932

Merged
merged 1 commit into from Dec 13, 2021
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Dec 13, 2021

What this PR does / why we need it:

To avoid unexpected triggering deployments in chain, should make this onChain trigger as disabled by default.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 31.53%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Dec 13, 2021

👍
Btw, In the future, we can allow specifying more policies in that OnChain field, such as the application owner can use labels to specify a whitelist of which can trigger the application.

@nghialv
Copy link
Member

nghialv commented Dec 13, 2021

/lgtm

@nakabonne
Copy link
Member

we can allow specifying more policies in that OnChain field

That's the case

@nakabonne
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nakabonne.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit d133bfa into master Dec 13, 2021
@pipecd-bot pipecd-bot deleted the chain-on-chain-trigger-default branch December 13, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants