Fix datatype passed to LOG() on x86_64 systems #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value passed to LOG() function was formatted as %lu, which on my 64-bit system leads to read uninitialised value, like this following line in log file: NOTICE: AddOnLog: VDR VNSI Client: Logged in at '1305641887+7200' to 'VDR-Network-Streaming-Interface (VNSI) Server' Version: '0.0.1' with protocol version '140685948747778' valgrind snipset for this error: ==21758== Use of uninitialised value of size 8 ==21758== at 0xC91EF0B: _itoa_word (_itoa.c:195) ==21758== by 0xC9213B6: vfprintf (vfprintf.c:1619) ==21758== by 0xC9433B8: vsprintf (iovsprintf.c:43) ==21758== by 0x1DC30D72: XBMC_log (libXBMC_addon.cpp:75) ==21758== by 0x1DA281DB: cXVDRSession::Login() (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x1DA235B8: cXVDRData::Login() (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x1DA1F8D8: ADDON_Create (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x84A865: ADDON::CAddonDll<DllPVRClient, PVRClient, PVR_PROPERTIES>::Create() (AddonDll.h:200) ==21758== by 0x8448EA: PVR::CPVRClient::Create(int) (PVRClient.cpp:107) ==21758== by 0x84EFC3: PVR::CPVRClients::InitialiseClient(boost::shared_ptr<ADDON::IAddon>) (PVRClients.cpp:1109) ==21758== by 0x8523F8: PVR::CPVRClients::UpdateAndInitialiseClients(bool) (PVRClients.cpp:1149) ==21758== by 0x852682: PVR::CPVRClients::Process() (PVRClients.cpp:1199) ==21758== ==21758== Conditional jump or move depends on uninitialised value(s) ==21758== at 0xC91EF15: _itoa_word (_itoa.c:195) ==21758== by 0xC9213B6: vfprintf (vfprintf.c:1619) ==21758== by 0xC9433B8: vsprintf (iovsprintf.c:43) ==21758== by 0x1DC30D72: XBMC_log (libXBMC_addon.cpp:75) ==21758== by 0x1DA281DB: cXVDRSession::Login() (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x1DA235B8: cXVDRData::Login() (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x1DA1F8D8: ADDON_Create (in /usr/local/lib/xbmc/addons/pvr.vdr.xvdr/XBMC_VDR_xvdr.pvr) ==21758== by 0x84A865: ADDON::CAddonDll<DllPVRClient, PVRClient, PVR_PROPERTIES>::Create() (AddonDll.h:200) ==21758== by 0x8448EA: PVR::CPVRClient::Create(int) (PVRClient.cpp:107) ==21758== by 0x84EFC3: PVR::CPVRClients::InitialiseClient(boost::shared_ptr<ADDON::IAddon>) (PVRClients.cpp:1109) ==21758== by 0x8523F8: PVR::CPVRClients::UpdateAndInitialiseClients(bool) (PVRClients.cpp:1149) ==21758== by 0x852682: PVR::CPVRClients::Process() (PVRClients.cpp:1199)
|
Merged. |
pipelka
added a commit
that referenced
this pull request
Sep 13, 2011
Fix datatype passed to LOG() on x86_64 systems
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am sending you the last bugfix for the error detected with valgrind. The xvdr plugin doesn't generate any more errors on my system (besides some errors in libz.so - but this is another story).
regards :)