Skip to content

Conversation

@suutaku
Copy link
Contributor

@suutaku suutaku commented Jan 11, 2023

Summary

uncatched serializer error will course crash

Basic example

Frame with invalid type of schema. for example, with @context https://w3id.org/citizenship/v1 , change PermanentResidentCard to PermanentResidentCar, program will crash

Motivation

service use jsonld should not crash

@suutaku suutaku changed the title should serializer error should return serializer error Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Base: 79.93% // Head: 79.88% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (7f5119b) compared to base (c70834a).
Patch coverage: 25.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   79.93%   79.88%   -0.05%     
==========================================
  Files          20       20              
  Lines        6179     6180       +1     
==========================================
- Hits         4939     4937       -2     
- Misses        958      960       +2     
- Partials      282      283       +1     
Impacted Files Coverage Δ
ld/processor.go 66.08% <25.00%> (-0.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kazarena
Copy link
Member

Thank you, looks like an obvious omission.

@kazarena kazarena merged commit 6ddbe6e into piprate:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants