New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] interfaces #192

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pirapira
Owner

pirapira commented Aug 11, 2017

Fixes #177

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 11, 2017

Owner

I need to go back to Byzantium preparation. Feel free to take it.

Owner

pirapira commented Aug 11, 2017

I need to go back to Byzantium preparation. Feel free to take it.

@pirapira pirapira changed the title from wip interfaces to [wip] interfaces Aug 11, 2017

@tjade273

This comment has been minimized.

Show comment
Hide comment
@tjade273

tjade273 Aug 12, 2017

Contributor

I've started implementing this feature.

Contributor

tjade273 commented Aug 12, 2017

I've started implementing this feature.

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 12, 2017

Owner

That's super cool.

Owner

pirapira commented Aug 12, 2017

That's super cool.

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Aug 21, 2017

Owner

@tjade273 I guess, after working for a while on the codebase, you've found suggestions for improvements in the existing codebase. Feel free to open issues or ping me on the gitter channel.

Owner

pirapira commented Aug 21, 2017

@tjade273 I guess, after working for a while on the codebase, you've found suggestions for improvements in the existing codebase. Feel free to open issues or ping me on the gitter channel.

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Sep 1, 2017

Owner

@tjade273 how's it going? When you don't have time, I can pick up and continue from where you are.

Owner

pirapira commented Sep 1, 2017

@tjade273 how's it going? When you don't have time, I can pick up and continue from where you are.

@tjade273

This comment has been minimized.

Show comment
Hide comment
@tjade273

tjade273 Sep 1, 2017

Contributor

Sorry for the long turnaround, I didn't manage to finish before school started so progress slowed a bit. I'll probably submit a PR this weekend though

Contributor

tjade273 commented Sep 1, 2017

Sorry for the long turnaround, I didn't manage to finish before school started so progress slowed a bit. I'll probably submit a PR this weekend though

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Sep 1, 2017

Owner

Thank you.

Owner

pirapira commented Sep 1, 2017

Thank you.

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Nov 9, 2017

Owner

@tjade273 please indicate if you don't have time so that others could take this over.

Owner

pirapira commented Nov 9, 2017

@tjade273 please indicate if you don't have time so that others could take this over.

@tjade273

This comment has been minimized.

Show comment
Hide comment
@tjade273

tjade273 Nov 16, 2017

Contributor

Oh man, I'm sorry. I haven't gotten around to working on this much so someone else should definitely take this over. Sorry to hold this feature up, I'll try at some point in the future to tackle another feature when I'm sure I have the time

Contributor

tjade273 commented Nov 16, 2017

Oh man, I'm sorry. I haven't gotten around to working on this much so someone else should definitely take this over. Sorry to hold this feature up, I'll try at some point in the future to tackle another feature when I'm sure I have the time

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira

pirapira Nov 17, 2017

Owner

@tjade273 thank you! Certainly, we can use your parser.

Owner

pirapira commented Nov 17, 2017

@tjade273 thank you! Certainly, we can use your parser.

@pirapira

This comment has been minimized.

Show comment
Hide comment
@pirapira
Owner

pirapira commented Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment