New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply "Open new blank tab as ..." option for "Ctrl-T" #1038

Open
mnieber opened this Issue Jan 30, 2016 · 13 comments

Comments

Projects
None yet
3 participants
@mnieber

mnieber commented Jan 30, 2016

Currently, to add a blank tab to a Tree, I press Ctrl+T to open a new tab window, and then move it into the desired Tree. What I would like to do is to right-click the Tree and choose Add new Tab, which should insert a blank Tab into that Tree (as a child of the Tree). This would be more direct and less fiddly.

@mnieber

This comment has been minimized.

Show comment
Hide comment
@mnieber

mnieber Feb 3, 2016

I see that I can use the option to add blank tabs always as a child of the current tab. The sequence is then to select a parent tab and then press ctrl+t, which is just as good.

mnieber commented Feb 3, 2016

I see that I can use the option to add blank tabs always as a child of the current tab. The sequence is then to select a parent tab and then press ctrl+t, which is just as good.

@mnieber mnieber closed this Feb 3, 2016

@piroor piroor reopened this Feb 3, 2016

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Feb 3, 2016

Owner

Did you close this unexpectedly?

If you like, you can assign "open new child tab" to middle-click on the "+" button. Sadly, you cannot do similar config for the keyboard shortcut like Ctrl-Shift-T - it is already used for "undo close tab".

Owner

piroor commented Feb 3, 2016

Did you close this unexpectedly?

If you like, you can assign "open new child tab" to middle-click on the "+" button. Sadly, you cannot do similar config for the keyboard shortcut like Ctrl-Shift-T - it is already used for "undo close tab".

@mnieber

This comment has been minimized.

Show comment
Hide comment
@mnieber

mnieber Feb 3, 2016

I closed it because I thought I found an alternative solution, but for some reason it is not working: new blank tabs created with ctrl+t do not become a child of the current tab.

So yes, it might still make sense to have a context menu option to insert a blank tab, where clicking this menu option would be equivalent to clicking the tab and pressing ctrl+t.

mnieber commented Feb 3, 2016

I closed it because I thought I found an alternative solution, but for some reason it is not working: new blank tabs created with ctrl+t do not become a child of the current tab.

So yes, it might still make sense to have a context menu option to insert a blank tab, where clicking this menu option would be equivalent to clicking the tab and pressing ctrl+t.

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Feb 10, 2016

Owner

BTW my another addon New Tab from Location Bar https://addons.mozilla.org/firefox/addon/new-tab-from-location-bar/ possibly helps you. It provides ability to open new child tab when you type an URL into the location bar.

And, if you hope to open a link or an URL text in the current page as new sibling tab, you can do it by drag the link (or the URL text) and drop it between existing tabs.

Owner

piroor commented Feb 10, 2016

BTW my another addon New Tab from Location Bar https://addons.mozilla.org/firefox/addon/new-tab-from-location-bar/ possibly helps you. It provides ability to open new child tab when you type an URL into the location bar.

And, if you hope to open a link or an URL text in the current page as new sibling tab, you can do it by drag the link (or the URL text) and drop it between existing tabs.

@aldanor

This comment has been minimized.

Show comment
Hide comment
@aldanor

aldanor Sep 27, 2017

I'm trying to figure whether Ctrl-T could be made to open tabs as either children or sibling, whichever.

Currently, I have it set as (new version on FF58)

New Tab Behaviour > Open new blank tab as > a sibling of a current tab

... and it doesn't seem to do anything, Ctrl-T would always open tabs at the very bottom of the tree. Is this to be expected?

aldanor commented Sep 27, 2017

I'm trying to figure whether Ctrl-T could be made to open tabs as either children or sibling, whichever.

Currently, I have it set as (new version on FF58)

New Tab Behaviour > Open new blank tab as > a sibling of a current tab

... and it doesn't seem to do anything, Ctrl-T would always open tabs at the very bottom of the tree. Is this to be expected?

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 27, 2017

Owner

The option works for the "new tab" button in the sidebar. We need to do something more for Ctrl-T case.,,

Owner

piroor commented Sep 27, 2017

The option works for the "new tab" button in the sidebar. We need to do something more for Ctrl-T case.,,

@piroor piroor changed the title from Allow to create a blank Tab directly inside a Tree to Apply "Open new blank tab as ..." option for "Ctrl-T" Sep 27, 2017

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 27, 2017

Owner

Currently it is impossible to know the reason why a new tab is opened. So we need to suppose to the reason from something available hints. For example: Adding new option like [ ] Consider a new tab with the url [about:newtab (*textbox)] as "new blank tab opened by a keyboard operation".

Owner

piroor commented Sep 27, 2017

Currently it is impossible to know the reason why a new tab is opened. So we need to suppose to the reason from something available hints. For example: Adding new option like [ ] Consider a new tab with the url [about:newtab (*textbox)] as "new blank tab opened by a keyboard operation".

@aldanor

This comment has been minimized.

Show comment
Hide comment
@aldanor

aldanor Sep 27, 2017

Yea maybe something like that. Note that new tabs can be overridden (e.g. 'New Tab Override' extension) to something like about:home which is what some people prefer. For most, it would be about:newtab I guess.

aldanor commented Sep 27, 2017

Yea maybe something like that. Note that new tabs can be overridden (e.g. 'New Tab Override' extension) to something like about:home which is what some people prefer. For most, it would be about:newtab I guess.

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 27, 2017

Owner

Done by recent commits.

Owner

piroor commented Sep 27, 2017

Done by recent commits.

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 27, 2017

Owner

There is another problem that a new next sibling tab breaks tree structure, hmm...

Owner

piroor commented Sep 27, 2017

There is another problem that a new next sibling tab breaks tree structure, hmm...

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 28, 2017

Owner

Recent commits fixes the invalid positioning problem, and we've reached at the goal: Apply "Open new blank tab as ..." option for "Ctrl-T".

One left problem is: if you hit Ctrl-T multiple times quickly, then they will be uncontrolled, because such new tabs are opened with a URL "about:blank" instead of "about:newtab". Firefox always prepares one new blank tab with the URL "about:newtab" in the background for quick response, and after you actually open a new blank tab, there is no more prepared new tab. If you hit new Ctrl-T before the next "about:newtab" tab is completely prepared, Firefox opens an "about:blank" tab and loads "about:newtab" after the tab is opened. Then we cannot detect the tab is actually opened by Ctrl-T or opened by other reasons like bookmarks. (Actually new tab opened from bookmark is also created with "about:blank" URL at first.) Sadly there is no solution to resolve this problem, this is a limitation of WebExtensions API system.

Owner

piroor commented Sep 28, 2017

Recent commits fixes the invalid positioning problem, and we've reached at the goal: Apply "Open new blank tab as ..." option for "Ctrl-T".

One left problem is: if you hit Ctrl-T multiple times quickly, then they will be uncontrolled, because such new tabs are opened with a URL "about:blank" instead of "about:newtab". Firefox always prepares one new blank tab with the URL "about:newtab" in the background for quick response, and after you actually open a new blank tab, there is no more prepared new tab. If you hit new Ctrl-T before the next "about:newtab" tab is completely prepared, Firefox opens an "about:blank" tab and loads "about:newtab" after the tab is opened. Then we cannot detect the tab is actually opened by Ctrl-T or opened by other reasons like bookmarks. (Actually new tab opened from bookmark is also created with "about:blank" URL at first.) Sadly there is no solution to resolve this problem, this is a limitation of WebExtensions API system.

@aldanor

This comment has been minimized.

Show comment
Hide comment
@aldanor

aldanor Sep 28, 2017

That's probably "ok" since spamming Ctrl-T is a questionable exercise anyway... Just out of wonder, how quickly is "quickly"?

aldanor commented Sep 28, 2017

That's probably "ok" since spamming Ctrl-T is a questionable exercise anyway... Just out of wonder, how quickly is "quickly"?

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 28, 2017

Owner

Currently I have no answer - we need to research the trigger to prepare new blank tab in the background.

Owner

piroor commented Sep 28, 2017

Currently I have no answer - we need to research the trigger to prepare new blank tab in the background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment