New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tab not visually showing until moving mouse #1202

Open
Fanolian opened this Issue Oct 6, 2016 · 8 comments

Comments

Projects
None yet
5 participants
@Fanolian

Fanolian commented Oct 6, 2016

Short description

New tab is not shown immediately on tab bar after opening.
This is a new issue since Nightly 2016-10-06 build. Mozregression points to Bug 1307100 - Floating toolbar does not hide when the selection highlight is scrolled out of viewport.

Steps to reproduce

  1. Start current Nightly (2016-10-06) with clean profile.
  2. Install TST nightly.
  3. Open a new tab by any means. CTRL-T, middle click a link, open addons manager from hamburger menu, etc..
  4. Don't move the mouse and observe the tab bar.

Expected result

New tab is shown on the tab bar.

Actual result

The new tab is missing from tab bar visually but it is actually accessible.

Workaround

There are many ways to let the new tab appear:
1a. If mouse is in content window, move mouse onto tab bar or URL bar.
1b. If mouse is already on tab bar, move mouse out of tab bar, or onto tab bar 1 tab above at where the new tab is supposed to be.
2. Switch to another window.
3. Press some particular keystrokes, e.g. CTRL, ALT, SHIFT, F3 (not 100% working)

Environment

  • Platform (OS): Windows 10 AU
  • Version of Firefox: current Nightly
  • Version (or revision) of Tree Style Tab: 0.18.2016091500a222113
@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Oct 7, 2016

Owner

The bug https://bugzilla.mozilla.org/show_bug.cgi?id=1307100 seems not the cause of this problem because it changes only a Java source file for Android.

Owner

piroor commented Oct 7, 2016

The bug https://bugzilla.mozilla.org/show_bug.cgi?id=1307100 seems not the cause of this problem because it changes only a Java source file for Android.

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Oct 12, 2016

Owner

I've realized that the "opacity" is unexpectedly "0" on such invisible tab. Expected computed value is "1".

Owner

piroor commented Oct 12, 2016

I've realized that the "opacity" is unexpectedly "0" on such invisible tab. Expected computed value is "1".

piroor added a commit that referenced this issue Oct 12, 2016

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Oct 12, 2016

Owner

The commit 23843af seems to fix this problem on my environment.

Owner

piroor commented Oct 12, 2016

The commit 23843af seems to fix this problem on my environment.

@piroor piroor added the maybe fixed label Oct 12, 2016

@Fanolian Fanolian changed the title from New tab not visually showing until moving mouse due to bug 1307100 to New tab not visually showing until moving mouse Oct 13, 2016

@Fanolian

This comment has been minimized.

Show comment
Hide comment
@Fanolian

Fanolian Oct 13, 2016

Fixed for me too. Thanks a lot

Fixed for me too. Thanks a lot

@Fanolian Fanolian closed this Oct 13, 2016

@Fanolian

This comment has been minimized.

Show comment
Hide comment
@Fanolian

Fanolian Oct 13, 2016

Upon further testing, the commit does not fix the condition when restoring a few closed tabs in a row.

Steps to reproduce:

  1. In Nighlty, install TST nightly. Restart browser.
  2. Open a bunch of tabs and then close some.
  3. Restore a few closed tabs consecutively (ctrl-shift-T).

Actual result:
tst tab visibility
The first restored tab may display correctly but not for other restored tabs.

Upon further testing, the commit does not fix the condition when restoring a few closed tabs in a row.

Steps to reproduce:

  1. In Nighlty, install TST nightly. Restart browser.
  2. Open a bunch of tabs and then close some.
  3. Restore a few closed tabs consecutively (ctrl-shift-T).

Actual result:
tst tab visibility
The first restored tab may display correctly but not for other restored tabs.

@Fanolian Fanolian reopened this Oct 13, 2016

@piroor piroor added partially fixed and removed maybe fixed labels Oct 13, 2016

@hiikezoe

This comment has been minimized.

Show comment
Hide comment
@hiikezoe

hiikezoe Oct 14, 2016

We've a report of this issue.
https://bugzilla.mozilla.org/show_bug.cgi?id=1309837

This issue is definitely caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1304922 .
@piroor can you please clarify this issue is a problem inside Gecko or inside this extension? I mean I'd like to know the code before the commit 23843af had been working accidentally or not.

Thanks,

hiikezoe commented Oct 14, 2016

We've a report of this issue.
https://bugzilla.mozilla.org/show_bug.cgi?id=1309837

This issue is definitely caused by https://bugzilla.mozilla.org/show_bug.cgi?id=1304922 .
@piroor can you please clarify this issue is a problem inside Gecko or inside this extension? I mean I'd like to know the code before the commit 23843af had been working accidentally or not.

Thanks,

@talklittle

This comment has been minimized.

Show comment
Hide comment
@talklittle

talklittle Mar 8, 2017

Contributor

Getting the bug on Firefox 52.0 on Ubuntu, TST version 0.18.2016111701, Plain theme, clean profile.

Did not experience the bug on Firefox 51 with same TST version and theme.

Cannot reproduce the bug on Firefox 53.0a2 with TST git @ b601787 which may be a good sign.

Contributor

talklittle commented Mar 8, 2017

Getting the bug on Firefox 52.0 on Ubuntu, TST version 0.18.2016111701, Plain theme, clean profile.

Did not experience the bug on Firefox 51 with same TST version and theme.

Cannot reproduce the bug on Firefox 53.0a2 with TST git @ b601787 which may be a good sign.

@cherrmann89

This comment has been minimized.

Show comment
Hide comment
@cherrmann89

cherrmann89 Mar 10, 2017

Workaround for Windows 10 Version 1607 Build 14393.693, Firefox 52.0 32bit:
set 'browser.tabs.animate' to false in about:config

Workaround for Windows 10 Version 1607 Build 14393.693, Firefox 52.0 32bit:
set 'browser.tabs.animate' to false in about:config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment