Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Drag as Child" is difficult to perform with tab animation #399

Closed
Fanolian opened this issue Nov 10, 2012 · 22 comments

Comments

Projects
None yet
@Fanolian
Copy link

commented Nov 10, 2012

Maybe it is just me, but I find it difficult to drag a tab as another's child with the introduction of tab animation.

Video about my concern, recorded with Nightly 20121109 build and only TST 0.14.2012111001 installed:
http://www.youtube.com/watch?v=C8r0XOCX0QE

Is there anything I can do to make the dragging easier?

@piroor

This comment has been minimized.

Copy link
Owner

commented Nov 11, 2012

Workaround: mousedown on a position near the upper or lower edge of tab and drag it, then it is easily dropped on another tab.

@mausalimi

This comment has been minimized.

Copy link

commented Nov 11, 2012

i also find it hard to drag tabs since the animation is introduced.

it's never clear where the tab really will go to, compared to older versions of TST.
i'm using the "sidebar" theme and know there is a mix of both, animation and "old style" dragging markers

@AlanLynn

This comment has been minimized.

Copy link

commented Nov 20, 2012

Even without this problem, I think I prefer the old dragging behavior. Maybe make it an option?

@Tragen

This comment has been minimized.

Copy link

commented Nov 29, 2012

Same here. An option to disable the animation and get back the old behavior would be great.
I don't know if also the drop targets changed but it's much harder now to do what I want.
When I drag a image in a site do my desktop and I move over the tree, some tabs get loaded and one of the tabs gets focus. Is this the same "bug"?

@piroor

This comment has been minimized.

Copy link
Owner

commented Nov 29, 2012

By these commits, tabs can be dropped to other tabs easily. Experimental builds from the latest code base at http://piro.sakura.ne.jp/xul/xpi/nightly/ , so try it please.

@Fanolian

This comment has been minimized.

Copy link
Author

commented Nov 30, 2012

Thanks for the update. I can rearrange the tabs correctly ~80% of the time now with the nightly build.
I still have problem swapping place of 2 adjacent parent tabs (with no children attached to both of them), especially when I move the lower tab up. It seems easier if I drag the upper tab down instead.

@Fanolian Fanolian closed this Nov 30, 2012

@Fanolian

This comment has been minimized.

Copy link
Author

commented Nov 30, 2012

clicked the wrong button

@Fanolian Fanolian reopened this Nov 30, 2012

@Infocatcher

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2012

Experimental builds from the latest code base at http://piro.sakura.ne.jp/xul/xpi/nightly/

Small bug:
Initial state:

[ Tab 1 ]
  [ Tab 2 ]
[ Tab 3 ]

Desired state:

[ Tab 1 ]
  [ Tab 2 ]
  [ Tab 3 ]

I can't drag tab 3 directly after tab 2, only over tab 1.

And the same with

[ Tab #1 ]
  [ Tab #2 ]
    [ Tab #3 ]

=>

[ Tab #1 ]
  [ Tab #2 ]
  [ Tab #3 ]

And unfortunately drag and drop still more difficult than old not animated behavior. :(

@Infocatcher

This comment has been minimized.

Copy link
Contributor

commented Nov 30, 2012

And strange things may happens after some drag and drop operations.

[ Tab 1 ]
  [ Tab 2 ]
[ Tab 3 ]
  [ Tab 4 ]

(and restart to take clear test)
Move:

[ Tab 3 ]
  [ Tab 4 ]
[ Tab 1 ]
  [ Tab 2 ]

Now try drag tab 1 (with child tab 2) over tab 4. I can't do this.
But can create wrong

[ Tab 3 ] (still parent for tab 4)
[ Tab 1 ] (still parent for tab 2, but not for 4)
  [ Tab 2 ]
  [ Tab 4 ]
@piroor

This comment has been minimized.

Copy link
Owner

commented Nov 30, 2012

And unfortunately drag and drop still more difficult than old not animated behavior. :(

There is an important thing: tab dragging animation is a feature of Firefox itself. Because TST is not an addon named as "animation disabler", I think TST should repeat Firefox's behaviors as possible as I can. Disabling animation should be done by another addon created for the purpose...

@mausalimi

This comment has been minimized.

Copy link

commented Dec 3, 2012

[ Tab 1 ]
...[ Tab 2 ]
[ Tab 3 ]
...[ Tab 4 ]

i can't even move group with tab 1 right below group with tab 3. as soon as i release, the group
moves back to the old position.
if another single tab is between, it works.

@Infocatcher

This comment has been minimized.

Copy link
Contributor

commented Dec 8, 2012

Another related issue: wrong drop markers for not-tabs (bookmarks, links, external links from another applications).

@lewisaronmilne

This comment has been minimized.

Copy link

commented Dec 11, 2012

Is there animation disabler add-on like the one you speak of? I can't find one.

Without one this add-on does not work properly, it is still better than nothing but I really want to just have it like it was.

@Infocatcher

This comment has been minimized.

Copy link
Contributor

commented Dec 11, 2012

wrong drop markers for not-tabs (bookmarks, links, external links from another applications).

Error: TypeError: draggedTab is null
Source file: resource://treestyletab-modules/tabbarDNDObserver.js
Line: 270

@mpolicki

This comment has been minimized.

Copy link

commented Dec 13, 2012

I confirm this issue. Since the introduction of the new drag&drop behavior, it has become very difficult to structure tabs, even in version 0.14.2012120800a034107. Please give us the option of using the old drag&drop behavior.

@rstarkov

This comment has been minimized.

Copy link

commented Dec 18, 2012

Hope a fix is coming. This is a huge problem for anyone who nests their tabs a lot. Me struggling with this: http://screencast.com/t/o6N8ryPs

@mausalimi

This comment has been minimized.

Copy link

commented Dec 18, 2012

@rstarkov

offtopic, but this is a very bad screen hoster, not only needs activated javascript, but even the $#@§@ flash plugin.
which i refuse to use.

@rstarkov

This comment has been minimized.

Copy link

commented Dec 18, 2012

@mausalimi If you're going to post off-topic anyway, you might as well at least suggest an alternative. I'll gladly switch if it's equally easy to use, in fact I rather hate Jing for being very slow to start.

@kaberett

This comment has been minimized.

Copy link

commented Apr 7, 2013

Still a problem in firefox 19.0.2 FWIW...

@machinegodzilla

This comment has been minimized.

Copy link

commented Apr 15, 2013

There are reports saying that toggling browser.tabs.animate and toolkit.scrollbox.smoothScroll to false fixes the problem but it's not true. I've downloaded an old version of Firefox just to recall how it was before and once you compare the behaviour side by side the difference is HUGE.

@piroor

Because TST is not an addon named as "animation disabler", I think TST should repeat Firefox's behaviors as possible as I can.

I understand what you are saying but at the same time this animation makes sense and looks nice for horizontal tabs but is a major annoyance and usability issue in TST. So regardless whether there is a standalone "animation disabler" addon out there I think that TST should include such disabler too for its own good.

@Fanolian

This comment has been minimized.

Copy link
Author

commented Jul 21, 2013

I am ok with the current implementation of this feature and no one replied/complained in the past 3 months. I am closing this issue as fixed.
Please file a new issue if anyone wants improvements for the current implementation. Thanks.

@Fanolian Fanolian closed this Jul 21, 2013

@dequis

This comment has been minimized.

Copy link

commented Jul 21, 2013

Yeah, i've been using the nightly builds lately, and it's actually decent. IMO the only problem left is that the position in which a tab / tabtree is left after dropping seems to be unpredictable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.