Removal of mozRequestAnimationFrame broke TST

[nnethercote]

https://bugzilla.mozilla.org/show_bug.cgi?id=909154 removed the prefixed version of mozAnimationRequestFrame from Firefox. As a result, Tree Style Tab is no longer working.

Here's an example of what TST should look like. This is the revision just before bug 909154's patch landed:

Here's what it looks like afterwards:

There is no nesting of tabs; clicking on the +/- buttons does nothing; middle-clicking on links does nothing; Ctrl-T does nothing. It's totally unusable.

[nnethercote]

I'm using version 0.15.2015030601.

[nnethercote]

I found version 0.15.2015061300a003855 at http://piro.sakura.ne.jp/xul/xpi/nightly/ and it's working, even though when I look in the .xpi file I still see uses of mozRequestionAnimationFrame. So now I'm confused.

Finding the latest version of TST is a confusing task.

[nnethercote]

I found version 0.15.2015061300a003855 at http://piro.sakura.ne.jp/xul/xpi/nightly/ and it's working, even though when I look in the .xpi file I still see uses of mozRequestAnimationFrame. So now I'm confused.

Today that version had the problem, so I hand-edited the .xpi file to change the two calls to mozRequestAnimationFrame to requestAnimationFrame and that fixed the problem again. So this appears to basically be a "get the code in the repository, which is good, into distributed .xpi files" issue.

[CrashNBurn71]

I switched back to Nightly 2015-07-19, for now anyways.
There's another NULL error with nightlies 07-21 thru 07-27.

Looks like Mozilla's updates are going to break User Style Manager, AND Session Manager as well. Lovely... I'll be done with FireFox if that's the case. Stylish is garbage (and when it breaks, you can't even access your css styles, as it DB stores them instead of plain text files), and FireFox's internal "session manager" is next to useless, and I'm certainly not installing TabMixPlus just for that.

[nnethercote]

I blogged about this, including my explanation of the work-around (which is to modify the code in-place).

[CrashNBurn71]

Mozilla has deprecated "LET" - which is used by TST and other extensions. That hammer will drop soon I imagine.

[asutherland]

Thanks for blogging about this, nnethercote, my sanity is much improved by having TreeStyle Tabs back!

CrashNBurn71, let as a whole is not deprecated. Let is an ES2015 standard. But Firefox/Gecko's JS Engine SpiderMonkey had some speculative features as part of the SpiderMonkey specific JS1.7 and JS1.8 releases. The pieces that didn't make it into the standard are being deprecated and removed, such as let expressions (https://bugzilla.mozilla.org/show_bug.cgi?id=1023609), but most existing code should be able to be made happy with a small amount of work.

[CrashNBurn71]

@asutherland
Thanks. It looks like most of the extensions using let that I can see are utilizing the block-scoping. Which makes the Browser Console error-output highly suspect, as it is just logging a deprecation message for _any_ usage of let.

[jryans]

This seems like a duplicate of #915, which should be fixed by 008a520 in master.

[nnethercote]

Indeed, it is a dup of #915.