New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metal: Fix sizing of selected pinned tabs #1192

Merged
merged 1 commit into from Sep 13, 2016

Conversation

Projects
None yet
2 participants
@talklittle
Contributor

talklittle commented Sep 13, 2016

Fixes #1191

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 13, 2016

Owner

Thanks! I have some questions:

  • If possible, could you describe how this change works? I'm afraid of regressions, so I hope to merge this change without such a worrying.
  • Does this change work as expected on three versions: Firefox 45ESR, Firefox 48, and Nightly 51.0a1? If this change breaks something on Firefox 45ESR, I think I have to do some hack to apply such version-specific rules only for newer versions of Firefox.
Owner

piroor commented Sep 13, 2016

Thanks! I have some questions:

  • If possible, could you describe how this change works? I'm afraid of regressions, so I hope to merge this change without such a worrying.
  • Does this change work as expected on three versions: Firefox 45ESR, Firefox 48, and Nightly 51.0a1? If this change breaks something on Firefox 45ESR, I think I have to do some hack to apply such version-specific rules only for newer versions of Firefox.
@talklittle

This comment has been minimized.

Show comment
Hide comment
@talklittle

talklittle Sep 13, 2016

Contributor

Works as expected in ESR 45.3.0, 48.0.1, Developer Edition 50.0a2, and Nightly 51.0a1.

Verified by installing Tree Style Tab from Mozilla Addons, and seeing the original bug (squashed pinned tabs when visually selected). Then replacing it with the locally built .xpi containing this PR's contents.

The change works by looking at the [visuallyselected] pinned tabs, and not altering the tab content margin/padding, so the pinned tab (containing just a favicon) can retain its normal size. It still gets highlighted when clicked.

Contributor

talklittle commented Sep 13, 2016

Works as expected in ESR 45.3.0, 48.0.1, Developer Edition 50.0a2, and Nightly 51.0a1.

Verified by installing Tree Style Tab from Mozilla Addons, and seeing the original bug (squashed pinned tabs when visually selected). Then replacing it with the locally built .xpi containing this PR's contents.

The change works by looking at the [visuallyselected] pinned tabs, and not altering the tab content margin/padding, so the pinned tab (containing just a favicon) can retain its normal size. It still gets highlighted when clicked.

@piroor piroor merged commit 972788a into piroor:master Sep 13, 2016

@talklittle

This comment has been minimized.

Show comment
Hide comment
@talklittle

talklittle Sep 13, 2016

Contributor

@piroor Thank you!

Contributor

talklittle commented Sep 13, 2016

@piroor Thank you!

@talklittle talklittle deleted the talklittle:fix-metal-pinned-tabs branch Sep 13, 2016

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 13, 2016

Owner

Perfect! Thanks again!

Owner

piroor commented Sep 13, 2016

Perfect! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment