New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compatibility with "How Many Times Can I Back?" (#397) #554

Merged
merged 2 commits into from Sep 12, 2013

Conversation

Projects
None yet
3 participants
@wanabe
Contributor

wanabe commented Sep 12, 2013

"getCommonAncestor" method is not available without jQuery

Improved compatibility with "How Many Times Can I Back?" (#397)
"getCommonAncestor" method is not available without jQuery
@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 12, 2013

Owner

Oops, I think I wanted to use DOMRange#commonAncestorContainer.
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-attr-commonParent
Could you rewrite your patch based on it?

Owner

piroor commented Sep 12, 2013

Oops, I think I wanted to use DOMRange#commonAncestorContainer.
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html#Level-2-Range-attr-commonParent
Could you rewrite your patch based on it?

Show outdated Hide outdated modules/browser.js
let container = containerFinder.getCommonAncestor();
let containerFinder = namedNodes.closeAnchor;
let containers = [];
while (containerFinder != aTab) {

This comment has been minimized.

@piroor

piroor Sep 12, 2013

Owner

In this project, I use the style:

while (...)
{

instead of

while (...) {

for "while", "for", "switch" blocks. So, in the future, please fit your patch to existing styles ;-)

@piroor

piroor Sep 12, 2013

Owner

In this project, I use the style:

while (...)
{

instead of

while (...) {

for "while", "for", "switch" blocks. So, in the future, please fit your patch to existing styles ;-)

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 12, 2013

Owner

One more. I basically use "git style" for commit messages in this project.
https://github.com/gitster/git/blob/master/Documentation/SubmittingPatches
So, "Improve compatibility..." is better.

Owner

piroor commented Sep 12, 2013

One more. I basically use "git style" for commit messages in this project.
https://github.com/gitster/git/blob/master/Documentation/SubmittingPatches
So, "Improve compatibility..." is better.

Improve compatibility with "How Many Times Can I Back?" (#397)
use commonAncestorContainer instead of getCommonAncestor()
@wanabe

This comment has been minimized.

Show comment
Hide comment
@wanabe

wanabe Sep 12, 2013

Contributor

Oh, sorry.
I rewrote the patch and commit log.

Contributor

wanabe commented Sep 12, 2013

Oh, sorry.
I rewrote the patch and commit log.

piroor added a commit that referenced this pull request Sep 12, 2013

Merge pull request #554 from wanabe/with-hmtcib
Improved compatibility with "How Many Times Can I Back?" (#397)

@piroor piroor merged commit d045439 into piroor:master Sep 12, 2013

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 12, 2013

Owner

Thanks a lot!

BTW, I hope you to cancel the old pull request (like this) and re-send new pull request without unnecessary commit (like 1a83376), In the next time.

Owner

piroor commented Sep 12, 2013

Thanks a lot!

BTW, I hope you to cancel the old pull request (like this) and re-send new pull request without unnecessary commit (like 1a83376), In the next time.

@kou

This comment has been minimized.

Show comment
Hide comment
@kou

kou Sep 12, 2013

You can rewrite commit message without creating a new pull request by git commit --amend and git push -f.

kou commented Sep 12, 2013

You can rewrite commit message without creating a new pull request by git commit --amend and git push -f.

@wanabe

This comment has been minimized.

Show comment
Hide comment
@wanabe

wanabe Sep 12, 2013

Contributor

Thank you for all of the advice!
I'll be careful in the future.

Contributor

wanabe commented Sep 12, 2013

Thank you for all of the advice!
I'll be careful in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment