New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly update "list all tabs" menu if there is pinned tabs #606

merged 1 commit into from Nov 18, 2013


None yet
2 participants

Infocatcher commented Nov 18, 2013

Also may be fixed using following way:

        var startPos = tabs.length - items.length; // Pinned tabs aren't displayed in menu
        for (let i = startPos, maxi = tabs.length; i < maxi; i++)
            items[i - startPos].style.marginLeft = tabs[i].getAttribute(this.kNEST)+'em';

But using of built-in tab property is better, I think.

piroor added a commit that referenced this pull request Nov 18, 2013

Merge pull request #606 from Infocatcher/fix_pinned_tabs
Correctly update "list all tabs" menu if there is pinned tabs

@piroor piroor merged commit 334dd58 into piroor:master Nov 18, 2013


This comment has been minimized.

Show comment
Hide comment

piroor Nov 18, 2013


Thanks a lot!!


piroor commented Nov 18, 2013

Thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment