New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix treestyletab in multiprocess (e10s) firefox #760

Merged
merged 3 commits into from Sep 30, 2014

Conversation

Projects
None yet
7 participants
@Nephyrin
Contributor

Nephyrin commented Aug 27, 2014

With these changes the addon appears to mostly work well in multiprocess mode. The changes are:

  • Fix onBeforeOpenLinkWithParams hook in windowHelper to recognize the newer code from bug 1050447, so it works on nightly again
  • Workaround a contentWindowAsCPOW issue, see mozilla Bug 1042680 comment 15. This may be a firefox bug, but is easy to work around on the addon side for now.
  • Change onBeforeOpenLinkWithParams to onBeforeOpenLinkWithTab and just pass the current tab from the link hook. This is because params.linkNode is not set in multiprocess mode, and accessing content via CPOWs is unnecessary here.
@wsmwk

This comment has been minimized.

Show comment
Hide comment
@wsmwk

wsmwk Sep 1, 2014

Is there an xpi of this around? I thought there used to be a DL somewhere at https://github.com/piroor/treestyletab that included developement patches but I'm not finding it

wsmwk commented Sep 1, 2014

Is there an xpi of this around? I thought there used to be a DL somewhere at https://github.com/piroor/treestyletab that included developement patches but I'm not finding it

@Nephyrin

This comment has been minimized.

Show comment
Hide comment
@Nephyrin

Nephyrin Sep 2, 2014

Contributor

@wsmwk This hasn't been merged or reviewed by the addon author yet, so it wouldn't be in development builds either way. I have a copy of the build I'm using for e10s testing here, but it will not auto-update, so you'll need to take care to switch back to proper builds once they support e10s.

Contributor

Nephyrin commented Sep 2, 2014

@wsmwk This hasn't been merged or reviewed by the addon author yet, so it wouldn't be in development builds either way. I have a copy of the build I'm using for e10s testing here, but it will not auto-update, so you'll need to take care to switch back to proper builds once they support e10s.

@wsmwk

This comment has been minimized.

Show comment
Hide comment
@wsmwk

wsmwk Sep 2, 2014

very timely - I was just about to restart Firefox for another issue.

For the few minutes I'm using it working, and stable. Thanks.

wsmwk commented Sep 2, 2014

very timely - I was just about to restart Firefox for another issue.

For the few minutes I'm using it working, and stable. Thanks.

piroor added a commit that referenced this pull request Sep 30, 2014

Merge pull request #760 from Nephyrin/master
Fix treestyletab in multiprocess (e10s) firefox

@piroor piroor merged commit 8962230 into piroor:master Sep 30, 2014

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Sep 30, 2014

Owner

I apologize for this large delay. I've confirmed this works well. Thanks a lot!!

Owner

piroor commented Sep 30, 2014

I apologize for this large delay. I've confirmed this works well. Thanks a lot!!

@al2000

This comment has been minimized.

Show comment
Hide comment
@al2000

al2000 Oct 17, 2014

Middle-click still doesn't open as child tab but as top level tab
FF v.33.0
TST v.0.14.2014051101

al2000 commented Oct 17, 2014

Middle-click still doesn't open as child tab but as top level tab
FF v.33.0
TST v.0.14.2014051101

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Oct 18, 2014

Owner

Development build is available: http://piro.sakura.ne.jp/xul/xpi/nightly/

Owner

piroor commented Oct 18, 2014

Development build is available: http://piro.sakura.ne.jp/xul/xpi/nightly/

@ShardPhoenix

This comment has been minimized.

Show comment
Hide comment
@ShardPhoenix

ShardPhoenix Nov 7, 2014

Thanks, this also fixed this issue for me in FF 34.

Thanks, this also fixed this issue for me in FF 34.

@kunambi

This comment has been minimized.

Show comment
Hide comment
@kunambi

kunambi Nov 15, 2014

This also fixes the issue for Firefox Developer Edition

kunambi commented Nov 15, 2014

This also fixes the issue for Firefox Developer Edition

@calh

This comment has been minimized.

Show comment
Hide comment
@calh

calh Dec 11, 2014

👍 Thanks @piroor for linking the nightly builds here. I just upgraded to FF 34, and my Tree Style Tabs (stable) started seeing the middle click top tree issue. This bugfix seems to work great!

calh commented Dec 11, 2014

👍 Thanks @piroor for linking the nightly builds here. I just upgraded to FF 34, and my Tree Style Tabs (stable) started seeing the middle click top tree issue. This bugfix seems to work great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment