New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fullscreen issues #925

Merged
merged 2 commits into from Aug 18, 2015

Conversation

Projects
None yet
3 participants
@upsuper
Contributor

upsuper commented Aug 18, 2015

I am the Gecko developer who currently works on Fullscreen stuffs. I'm sorry that I didn't realize my change breaks addons like this. The commits fix the issues caused by two changes I made in Gecko. See the description for more details.

upsuper added some commits Aug 18, 2015

Fix sidebar in fullscreen mode for Firefox 40+.
This is a change from bug 947854 where FullScreen.mouseoverToggle is
replaced with FullScreen.{show,hide}NavToolbox. This fix detects this
and do patching accordingly.
Fix Fullscreen API issue for Firefox 41+.
This is a change from bug 1161802 which makes the "fullscreen" event be
triggered after window.fullScreen value flips.
@upsuper

This comment has been minimized.

Show comment
Hide comment
@upsuper

upsuper Aug 18, 2015

Contributor

This should fix #903 and #910.

Contributor

upsuper commented Aug 18, 2015

This should fix #903 and #910.

piroor added a commit that referenced this pull request Aug 18, 2015

@piroor piroor merged commit 4252c46 into piroor:master Aug 18, 2015

@piroor

This comment has been minimized.

Show comment
Hide comment
@piroor

piroor Aug 18, 2015

Owner

Thanks a lot!!!

Owner

piroor commented Aug 18, 2015

Thanks a lot!!!

@mlissner

This comment has been minimized.

Show comment
Hide comment
@mlissner

mlissner Sep 21, 2015

@upsuper, I'm just passing by, but thanks for being so conscientious. Rare is the developer that fixes downstream bugs like this one!

@upsuper, I'm just passing by, but thanks for being so conscientious. Rare is the developer that fixes downstream bugs like this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment