Skip to content
Commits on Jul 19, 2011
  1. @wapcaplet
Commits on Jul 1, 2011
  1. @wapcaplet

    Formatting

    wapcaplet committed Jul 1, 2011
  2. @wapcaplet

    Bumped to 0.2.2

    wapcaplet committed Jul 1, 2011
  3. @wapcaplet
Commits on Jun 30, 2011
  1. @wapcaplet
Commits on May 12, 2011
  1. @wapcaplet
  2. @wapcaplet
  3. @wapcaplet
  4. @wapcaplet
  5. @wapcaplet
Commits on May 11, 2011
  1. @wapcaplet

    Navigation self-tests, better exceptions

    - Added navigation.feature and navigation_fail.feature, to self-test
      the go to / follow / press / next to step definitions
    - Added MissingLink, MissingButton, MissingRow, InvalidScope exceptions
    - Backend further uglified to handle ambiguous Capybara exceptions, but
      at least now the frontend will be a little friendlier
    wapcaplet committed May 11, 2011
  2. @wapcaplet
  3. @wapcaplet

    Eliminate 'I visit' stepdef from sinatra app

    Kelp's web_steps.rb includes an "I go to" / "I am on" step definition
    which was until this point untested. Turns out there were some problems
    with quoting (and probably similar problems with quoting in the "I
    should be on" stepdef). Started adding some cucumber self-tests for
    these. Also, the lack of defined 'path_to' made the existing stepdef
    untestable, so I've shifted the functionality into a new helper
    function, which still needs some documentation and further testing.
    wapcaplet committed May 11, 2011
  4. @wapcaplet
  5. @wapcaplet
  6. @wapcaplet

    Fix arity mismatch error

    wapcaplet committed May 11, 2011
  7. @wapcaplet

    Bumped to 0.2.0

    wapcaplet committed May 11, 2011
  8. @wapcaplet
  9. @wapcaplet

    Ugly overhaul of fill-in methods

    In order to raise more descriptive, Kelp-specific exceptions, some major
    uglification of the `select_or_fill` method was needed. Part of this
    difficulty is due to the fact that Capybara raises `ElementNotFound`
    both when a field does not exist at all, and when a dropdown field
    exists but does not include the expected value. An understandable state
    of affairs; but rather than having Kelp mimic this ambiguity, new
    exceptions `FieldNotFound` and `OptionNotFound` were added.
    
    I suspect even more exception types will be needed in the near future
    (especially to disambiguate the many uses of Kelp::Unexpected). It may
    also become necessary to split the form-field-filling from the
    form-field-verification methods, since field.rb is getting pretty
    longish.
    wapcaplet committed May 10, 2011
Commits on May 10, 2011
  1. @wapcaplet
  2. @wapcaplet
  3. @wapcaplet
  4. @wapcaplet
  5. @wapcaplet
  6. @wapcaplet
  7. @wapcaplet

    Refactor visibility methods

    Six(!) of the visibility methods have been made obsolete, and are now
    marked deprecated. They will probably be removed in Kelp 0.2.1 or so.
    
    - page_should_contain
    - page_should_not_contain
    - page_should_contain_text
    - page_should_not_contain_text
    - page_should_contain_regexp
    - page_should_not_contain_regexp
    
    These were all replaced by `page_contains?`, which returns a true/false
    value, and is easier to use when selecting out unexpected results
    anyway.
    wapcaplet committed May 9, 2011
Commits on May 9, 2011
  1. @wapcaplet

    Remove failed Webrat support

    It doesn't look like Webrat support is going to be very feasible without
    extensive uglification of Kelp's methods; Capybara seems to have
    superseded Webrat anyway, and I'm personally not that interested in
    keeping Webrat support. Taking out my abortive attempt at adding Webrat
    support; if someone wants to contribute Webrat support to Kelp some day,
    I'll be happy to add it. Until then, there's no reason to keep this
    stuff in the code.
    wapcaplet committed May 9, 2011
  2. @wapcaplet

    Updated History

    wapcaplet committed May 9, 2011
  3. @wapcaplet

    More failure tests, more Kelp::Unexpected

    - Checkbox and dropdown steps now raise Kelp::Unexpected, instead of
      RSpec::ExpectationNotMetError
    - dropdown_should(_not?)_include accumulates unexpected strings, instead
      of failing on the first one
    - Added several more checkbox-failure and dropdown-failure scenarios
    wapcaplet committed May 9, 2011
  4. @wapcaplet

    Improve visibility_fail verification

    'results should include' now checks for each line in order, rather than
    blocks of text at a time. This allows somewhat clearer specification of
    expected output.
    wapcaplet committed May 9, 2011
Commits on May 8, 2011
  1. @wapcaplet

    Visibility failure improvements

    - *_same_row now raises Kelp::Unexpected with a friendly message,
      instead of RSpec::ExpectationNotMetError with an unfriendly
      xpath-related message
    - Fixed visibility spec tests to account for the above change
    - Added several more cucumber self-tests for visibility failure
    wapcaplet committed May 8, 2011
  2. @wapcaplet
  3. @wapcaplet

    Fixed argument-order bug

    wapcaplet committed May 8, 2011
  4. @wapcaplet

    Fix wonky quoting behavior in 'within' clause

    In order to support the `selector_for` method provided by recent
    versions of cucumber-rails, the 'within' clause was silently stripping
    off surrounding double-quotes. This caused some strange behavior when a
    quoted identifier was passed; although it seemed to work, Cucumber's
    output was omitting the initial " and duplicating the trailing
    character. Thus this:
    
        Then I should see "Foo" within "#bar"
    
    was outputted like this:
    
        Then I should see "Foo" within #barr"
    
    Modifying the WITHIN regex to swallow any leading and trailing
    double-quotes, and making the inner expression match anything except
    double-quotes, allows these to be treated correctly. This makes it
    unnecessary for the `within_scope` method to silently strip the quotes.
    wapcaplet committed May 7, 2011
Commits on May 6, 2011
  1. @wapcaplet
Something went wrong with that request. Please try again.