Permalink
Commits on Jun 8, 2012
  1. Rename test/same-name to test/same-source-file-name

    TEST=test/same-source-file-name
    
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1414 78cadc50-ecff-11dd-a971-7dbc132099af
    steveblock@chromium.org committed Jun 8, 2012
  2. Fix make backend to correctly handle rules with output files of the s…

    …ame name
    
    TEST=test/same-rule-output-file-name
    Review URL: http://codereview.chromium.org/10538055/
    Patch from Steve Block <steveblock@chromium.org>!
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1413 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed Jun 8, 2012
Commits on Jun 7, 2012
  1. ninja windows: support alternative entrypoints.

    'EntryPointSymbol' translates to /ENTRY: in linker flags.  This is needed by Chrome's mini_installer target.
    
    BUG=none
    TEST=python gyptest.py -f msvs,ninja test/win/gyptest-link-entrypointsymbol.py
    Review URL: https://chromiumcodereview.appspot.com/10544049
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1412 78cadc50-ecff-11dd-a971-7dbc132099af
    grt@chromium.org committed Jun 7, 2012
  2. Make backends robust to rules and actions containing slashes

    TEST=test/sanitize-rule-names/
    
    Review URL: http://codereview.chromium.org/10535052/
    Patch from Steve Block <steveblock@chromium.org>
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1411 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed Jun 7, 2012
Commits on May 31, 2012
  1. Fix bug in ninja/msvs/scons generator when there's no default action.

    In some cases, an action is only evaluated under certain conditions. 
    This works in the make generator, update the others to match.
    
    BUG=gyp:253
    TEST=python gyptest.py -a test/rules/gyptest-all.py passes 
    
    Review URL: http://codereview.chromium.org/10382161/
    Patch from Yaron Friedman <yfriedman@chromium.org>
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1410 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 31, 2012
  2. ninja windows: support resource only DLLs

    'ResourceOnlyDLL' translates to '/NOENTRY' in linker flags :/. Allows creating
    DLLs that contain only localized resources but no code.
    
    R=thakis@chromium.org
    BUG=chromium:130621
    
    Review URL: https://chromiumcodereview.appspot.com/10459059
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1409 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 31, 2012
  3. ninja windows: include gyp dir in rc build include dirs

    To match VS (and fix some .rc build steps in Chromium targets)
    
    BUG=chromium:128729
    
    Review URL: https://chromiumcodereview.appspot.com/10448103
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1408 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 31, 2012
  4. Add toolset support to dump_dependency_json.

    dump_dependency_json was only outputting #target targets, not #host. Add
    generator_supports_multiple_toolsets to get it to do the right thing.
    The resulting dependency info appears to be correct without any code
    changes.
    
    Review URL: http://codereview.chromium.org/10182004/
    Patch from Richard Coles <torne@chromium.org>!
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1407 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 31, 2012
  5. Minor cleanup.

    No functionality or performance change.
    Review URL: https://chromiumcodereview.appspot.com/10442115
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1406 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 31, 2012
Commits on May 30, 2012
  1. Mac: Test to make sure valid C/C++/Obj-C/Obj-C++ files compile with d…

    …ifferent flags.
    
    This change would, e.g., catch if -Wno-invalid-offsetof were given when building
    a C (or Obj-C) file.
    
    TEST=test/mac/gyptest-xcode-gcc.py
    Review URL: https://chromiumcodereview.appspot.com/10458043
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1405 78cadc50-ecff-11dd-a971-7dbc132099af
    viettrungluu@chromium.org committed May 30, 2012
  2. Assign value to LIB_DIR for ninja Linux build.

    Building libvpx on Linux requires knowledge of the static library file.
    Assign the directory path to LIB_DIR for ninja.
    Review URL: https://chromiumcodereview.appspot.com/10459029
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1404 78cadc50-ecff-11dd-a971-7dbc132099af
    hclam@chromium.org committed May 30, 2012
Commits on May 29, 2012
  1. Fixing make generator handling of multiple actions in a dependent tar…

    …get.
    
    Multiple actions in a single none target fail to all depend correctly on
    the stamps from all the targets that they are in depend on.
    
    test/actions-multiple has been enhanced to cover this case.
    
    BUG=https://code.google.com/p/chromium/issues/detail?id=129814
    TEST=test/actions-multiple
    R=thakis@chromium.org
    Review URL: https://chromiumcodereview.appspot.com/10454038
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1403 78cadc50-ecff-11dd-a971-7dbc132099af
    bradnelson@google.com committed May 29, 2012
Commits on May 28, 2012
  1. Add a few early exits to ExpandVariables.

    This makes the functions a bit less indented.
    No functionality change.
    Review URL: https://chromiumcodereview.appspot.com/10448042
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1402 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 28, 2012
  2. Update golden files after r1400.

    cd test/variables/commands ; ./update_golden ; cd -
    cd test/variables/filelist ; ./update_golden ; cd -
    
    TBR=scottmg
    Review URL: https://chromiumcodereview.appspot.com/10447059
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1401 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 28, 2012
  3. Speed up gyp 10% by removing a debug statement that's never used for …

    …anything in practice.
    
    If someone wants to debug this, they can just add a local print statement.
    
    32s -> 29.5s for ninjagyp on my machine.
    
    BUG=chromium:82230
    TEST=none
    Review URL: https://chromiumcodereview.appspot.com/10448041
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1400 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 28, 2012
  4. mac ninja/make: Do topological sort only once instead of at each access.

    Speeds up ninja gyp time on mac from 34s to 31.8s. 
    
    BUG=chromium:82230
    TEST=none
    Review URL: https://chromiumcodereview.appspot.com/10458006/
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1399 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 28, 2012
  5. mac ninja/make: Cache _sdk_base_dir at class level instead of instanc…

    …e level.
    
    Makes gyp with GYP_GENERATORS=ninja file generation 20% faster.
    
    BUG=82230
    TEST=none
    Review URL: https://chromiumcodereview.appspot.com/10451056
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1398 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 28, 2012
  6. ninja windows: support precompiled headers

    Make existing msvs-only test for PCH be msvs+ninja. Adds various flags to cflags and build rule in similar manner to existing Mac GCH support. Minor modifications to xcode_emulation to share top-level code between Windows and Mac.
    
    R=thakis@chromium.org
    BUG=126314
    Review URL: https://chromiumcodereview.appspot.com/10407108
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1397 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 28, 2012
Commits on May 25, 2012
  1. Add support for GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO to xcode emulat…

    …ion.
    
    Review URL: https://chromiumcodereview.appspot.com/10451028
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1395 78cadc50-ecff-11dd-a971-7dbc132099af
    viettrungluu@chromium.org committed May 25, 2012
  2. Fixing leftover from prior reveiew, plus more lint.

    Prior review:
    https://chromiumcodereview.appspot.com/10399131/
    
    Fixing more lint warnings.
    
    BUG=None
    TEST=None
    R=thakis@chromium.org
    Review URL: https://chromiumcodereview.appspot.com/10449026
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1394 78cadc50-ecff-11dd-a971-7dbc132099af
    bradnelson@google.com committed May 25, 2012
Commits on May 23, 2012
  1. ninja windows: support and test for AdditionalIncludeDirectories

    Normally gyp files use 'includes', or 'msvs_system_include_dirs', but the msvs
    generator supports AdditionalIncludeDirectories, so add support to ninja for
    consistency.
    
    BUG=127702
    
    Review URL: https://chromiumcodereview.appspot.com/10389225
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1393 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 23, 2012
Commits on May 22, 2012
  1. Made stab at fixing pylint warnings, supressing the rest.

    BUG=None
    TEST=None
    R=thakis@chromium.org,maruel@chromium.org
    Review URL: https://chromiumcodereview.appspot.com/10399131
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1392 78cadc50-ecff-11dd-a971-7dbc132099af
    bradnelson@google.com committed May 22, 2012
  2. Fixing mistake in the mapping of manifest settings from vcbuild to ms…

    …build.
    
    Mt should have been Manifest.
    Perils of tests that recaptiulate the implementation.
    
    BUG=http://code.google.com/p/gyp/issues/detail?id=222
    TEST=None
    R=scottmg@chromium.org,pkotwicz@google.com,robertshield@chromium.org
    Review URL: https://chromiumcodereview.appspot.com/10383282
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1391 78cadc50-ecff-11dd-a971-7dbc132099af
    bradnelson@google.com committed May 22, 2012
  3. Fixing hash escaping for msbuild.

    Similar to:
    http://code.google.com/p/gyp/source/detail?r=1388
    
    BUG=None
    TEST=None
    R=thakis@chromium.org
    Review URL: https://chromiumcodereview.appspot.com/10411071
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1390 78cadc50-ecff-11dd-a971-7dbc132099af
    bradnelson@google.com committed May 22, 2012
Commits on May 21, 2012
  1. Xcode: Allows mac_framework_headers to be included for non-bundle Mac…

    … targets.
    
    This allows static library targets to export headers like frameworks so they
    can be packaged up.
    
    BUG=chromium:129013
    
    Patch from Alastair Tse <altse@google.com>!
    
    
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1389 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 21, 2012
Commits on May 18, 2012
  1. Try to fix defines containing '#' characters with cl.exe.

    Review URL: https://chromiumcodereview.appspot.com/10408026
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1388 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 18, 2012
  2. Try to fix failing tests after 1386.

    TBR=scottmg
    Review URL: https://chromiumcodereview.appspot.com/10413004
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1387 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 18, 2012
  3. make: Support '#' characters in defines.

    TBR=evan
    Review URL: https://chromiumcodereview.appspot.com/10332236
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1386 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 18, 2012
Commits on May 17, 2012
  1. Allow multiple possibe error codes for the "status" parameter.

    Use this to make gyptest-objc-gc pass with both Xcode 3 and 4.
    Review URL: https://chromiumcodereview.appspot.com/10399072
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1385 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 17, 2012
  2. mac ninja and make: Add support for GCC_ENABLE_OBJC_GC.

    Review URL: https://chromiumcodereview.appspot.com/10409007
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1384 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 17, 2012
  3. Revert r1362: MSVS 2008: Fix to ensure that actions are re-run when t…

    …he command changes
    
    This change caused a performance regression in the Windows incremental
    build on the Chromium bots, because the bots are deleting the new
    .gypcmd files from the source tree between runs, which triggers a lot
    of rebuilding.
    
    It's not practical to add the .gypcmd files to all the svn:ignore
    lists, so I'm reverting the change until we find a better solution.
    
    BUG=http://code.google.com/p/gyp/issues/detail?id=262
    TEST=trybots
    
    Review URL: https://chromiumcodereview.appspot.com/10377171
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1383 78cadc50-ecff-11dd-a971-7dbc132099af
    mseaborn@chromium.org committed May 17, 2012
Commits on May 16, 2012
  1. msvs: add some touches to many-actions test to make sure incremental …

    …works correctly
    
    Per discussion here: https://chromiumcodereview.appspot.com/10387164/
    
    R=jeanluc@chromium.org
    
    Review URL: https://chromiumcodereview.appspot.com/10383222
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1382 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 16, 2012
  2. msvs: fix regression in r1378, environment not set up properly for mu…

    …ltiple actions on one input
    
    The previous method (only setup on first iteration of loop) didn't respect
    that the actions might be distributed across multiple input files, which are
    run as separate commands. Instead, only do setup_env for first action for a
    given input.
    
    R=grt@chromium.org,jeanluc@chromium.org
    BUG=gyp:261
    
    Review URL: https://chromiumcodereview.appspot.com/10387164
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1381 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 16, 2012
  3. ninja: Change the default target from 'build everything' to 'build ta…

    …rget "all"'.
    
    'all' are all targets transitively referenced by all.gyp.  For example:
    
    all.gyp:
      targets: [
        {
          'target_name': 'main_target',
          'dependencies': [
            'dep.gyp:target1',
          ],
        },
      ]
    
    dep.gyp:
      targets: [
        { 'target_name': 'target1' },
        { 'target_name': 'target2' },
      ]
    
    Here, 'all' does include target1 from dep.gyp, but not target2.
    The generator still writes a ninja file for target2, and it can
    be built with 'ninja target2', but just 'ninja' will no longer
    build it.
    
    BUG=127952
    TEST=Running just `ninja -C out/Release` doesn't produce errors.
    Review URL: https://chromiumcodereview.appspot.com/10399055
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1380 78cadc50-ecff-11dd-a971-7dbc132099af
    thakis@chromium.org committed May 16, 2012
  4. msvs: error out on actions w/o inputs

    r1378 broke on ninja, not because of command line too long, but because there was no inputs specified in the actions.
    
    Add inputs block to the actions in previously added test, make msvs error out in the same way as other generators. Add verification to input.py.
    
    R=thakis@chromium.org
    
    Review URL: https://chromiumcodereview.appspot.com/10387156
    
    git-svn-id: http://gyp.googlecode.com/svn/trunk@1379 78cadc50-ecff-11dd-a971-7dbc132099af
    scottmg@chromium.org committed May 16, 2012