From da730c76e98fb9fd18dac445dafbbec74d79f802 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sun, 22 Feb 2015 07:50:20 +0100 Subject: [PATCH] deps: enable node-gyp iojs.lib download checksum Originally disabled in commit 5de334c ("deps: make node-gyp work again on windows") due to the then-website lacking the requisite SHASUMS.txt or SHASUMS256.txt files. The website has a SHASUMS256.txt now so start checksumming the download again. PR-URL: https://github.com/iojs/io.js/pull/918 Reviewed-By: Rod Vagg Reviewed-By: Colin Ihrig --- deps/npm/node_modules/node-gyp/lib/install.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/deps/npm/node_modules/node-gyp/lib/install.js b/deps/npm/node_modules/node-gyp/lib/install.js index 378fbfae47..f9176b3ab0 100644 --- a/deps/npm/node_modules/node-gyp/lib/install.js +++ b/deps/npm/node_modules/node-gyp/lib/install.js @@ -295,8 +295,7 @@ function install (gyp, argv, callback) { // check content shasums for (var k in contentShasums) { log.verbose('validating download checksum for ' + k, '(%s == %s)', contentShasums[k], expectShasums[k]) - // TODO(piscisaureus) re-enable checksum verification when the correct files are in place. - if (false || contentShasums[k] !== expectShasums[k]) { + if (contentShasums[k] !== expectShasums[k]) { cb(new Error(k + ' local checksum ' + contentShasums[k] + ' not match remote ' + expectShasums[k])) return }