Issues with mousewheel with 1.1.3 in IE with jQuery 1.7 #105

Closed
pisi opened this Issue Feb 27, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@pisi
Owner

pisi commented Feb 27, 2012

Some of you reported issues with mousewheel in IE with latest jQuery.

Investigations revealed two separate problems (well, maybe they are interconnected on some level):

  1. In jQuery 1.7 IE fires its own "wheel" event on mousewheel (1.6 didn't do this). Unfortunately this event misses the distance handler parameter altogether. This causes Reel's internal "wheel" handler to be double fired and fail. To resolve this, "wheel" handler calls missing the distance parameter will be ignored by the handler.
  2. The mousewheel plug-in version 3.0.2 Reel uses for examples, tests and in the bundle also happens to be incompatible with jQuery 1.7. Brandon got this is resolved in latest version 3.0.6, so upgrade will be necessary for this fix (both in distribution and also on the CDN)

@ghost ghost assigned pisi Feb 27, 2012

pisi added a commit that referenced this issue Feb 27, 2012

Fixed jQuery 1.7 wheel issue #105 by ignoring `"wheel"` calls missing…
… the `distance` parameter and also by upgrading Brandon's mousewheel plug-in to 3.0.6.

pisi added a commit that referenced this issue Feb 27, 2012

Reel 1.1.4
Patching issues with jQuery 1.7 in IE (#93 and #105)

@pisi pisi closed this Feb 27, 2012

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 27, 2012

Owner

Note, that you must also upgrade your copy of the mousewheel plug-in with the included version 3.0.6. The one shipped with Reel 1.1.3 (mousewheel 3.0.4) was also jQuery 1.7 incompatible.

Owner

pisi commented Feb 27, 2012

Note, that you must also upgrade your copy of the mousewheel plug-in with the included version 3.0.6. The one shipped with Reel 1.1.3 (mousewheel 3.0.4) was also jQuery 1.7 incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment