New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-row Stitched Reels #129

Closed
stiliyan opened this Issue Jun 20, 2012 · 4 comments

Comments

Projects
None yet
2 participants
@stiliyan

stiliyan commented Jun 20, 2012

Would it be possible to add support for multirow reels where stitched images represent the rows?

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Jun 20, 2012

Owner

As right now rows and multi-row setups in general are limited only to framed setups, and are completely ignored by stitched setups, this feature will sure even things up a bit. Nice one :)

Owner

pisi commented Jun 20, 2012

As right now rows and multi-row setups in general are limited only to framed setups, and are completely ignored by stitched setups, this feature will sure even things up a bit. Nice one :)

pisi added a commit that referenced this issue Oct 12, 2012

Here are testing examples for #129. The goal is to have support for m…
…ulti-row stitched both when rows in one sprite and rows as individual images.

pisi added a commit that referenced this issue Oct 12, 2012

pisi added a commit that referenced this issue Oct 12, 2012

pisi added a commit that referenced this issue Oct 12, 2012

pisi added a commit that referenced this issue Oct 12, 2012

Alternatively `images` of rows can be supplied, which calls for adjus…
…tment of `$.reel.sequence()`, which when sensing stitched situation, acts as if each row has one frame. #129

pisi added a commit that referenced this issue Oct 12, 2012

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Oct 12, 2012

Owner

Hi @stiliyan, I finally git to your nice feature request and managed to pull off the majority of it. I know it took very long.. Some tuning is still required, but essentially it is functional now. Please see the dedicated stitched-multirow branch for details. There are two ways to setup essentially the same situations and both are covered by panorama-multi-row-stitched example. It works quite well and every aspect of the functionality is covered with unit tests, but I would still like to ask you to grab the code and do some testing if it fits your expectations.

I used your photos for both examples, but I feel it would be less confusing to have unique photo for each example. Can you spare one more? ;)

Cheers!

Owner

pisi commented Oct 12, 2012

Hi @stiliyan, I finally git to your nice feature request and managed to pull off the majority of it. I know it took very long.. Some tuning is still required, but essentially it is functional now. Please see the dedicated stitched-multirow branch for details. There are two ways to setup essentially the same situations and both are covered by panorama-multi-row-stitched example. It works quite well and every aspect of the functionality is covered with unit tests, but I would still like to ask you to grab the code and do some testing if it fits your expectations.

I used your photos for both examples, but I feel it would be less confusing to have unique photo for each example. Can you spare one more? ;)

Cheers!

pisi added a commit that referenced this issue Oct 12, 2012

pisi added a commit that referenced this issue Oct 12, 2012

@ghost ghost assigned pisi Oct 13, 2012

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 20, 2013

Owner

Merged into development branch awaiting release

Owner

pisi commented Feb 20, 2013

Merged into development branch awaiting release

@pisi pisi closed this Feb 20, 2013

pisi added a commit that referenced this issue Feb 23, 2013

Reel 1.2.1
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 23, 2013

Owner

Merged into master and included in today's version 1.2.1 release.

Owner

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment