Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hung in IE8 with jQuery 1.8 #140

Closed
pisi opened this issue Aug 15, 2012 · 5 comments
Closed

Hung in IE8 with jQuery 1.8 #140

pisi opened this issue Aug 15, 2012 · 5 comments
Assignees
@pisi
Labels
bug resolved
Milestone
1.2.1

Comments

@pisi
Copy link
Owner

pisi commented Aug 15, 2012

It appears something has changed in how $.unique() works and it now fails (or endlessly loops to be precise) with multiple documents. It is filed as a potential bug of jQuery 1.8.

These two lines causes IE8 to hang big time:

try{ pools= $.unique(pool.add(window.top.document)) }

Put aside the in my opinion correct expectation for jQuery to be able to decide whether two document objects are unique or not (afterall jQuery works just fine with document, right?), I'm thinking about making the comparison myself to work around this:

try{ if (pool[0] != top.document) pools= pool.add(top.document) }

It should have the exact same effect without the need for $.unique().
@ghost ghost assigned pisi Aug 15, 2012
@pisi
Copy link
Owner Author

pisi commented Aug 15, 2012

Ok, so as was explained to me, what I have there was actually a misuse of $.unique(), so that is a big no no for our purpose. I have big hopes for the workaround outlined above. Will test and see.

@pisi
Copy link
Owner Author

pisi commented Sep 4, 2012

For those, who want to give the workaround, it is available in fix-pools branch. If you do, please let me know if it resolved your issue or not. Thanks!

@pisi pisi mentioned this issue Sep 14, 2012
Closed
@pisi
Copy link
Owner Author

pisi commented Oct 10, 2012

Fix for this just made it into the development branch

@pisi
Copy link
Owner Author

pisi commented Oct 11, 2012

I've just verified this working in:

  • IE 8 and 9 on Win7
  • IE 6 and 7 on WinXP

@pisi pisi closed this as completed Oct 11, 2012
pisi added a commit that referenced this issue Feb 23, 2013
@pisi
Reel 1.2.1
ccea432 
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi
Copy link
Owner Author

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pisi pisi

Labels
bug resolved
Projects
None yet
Milestone
1.2.1
Development

No branches or pull requests
1 participant
@pisi