Hung in IE8 with jQuery 1.8 #140

Closed
pisi opened this Issue Aug 15, 2012 · 5 comments

Comments

Projects
None yet
1 participant
@pisi
Owner

pisi commented Aug 15, 2012

It appears something has changed in how $.unique() works and it now fails (or endlessly loops to be precise) with multiple documents. It is filed as a potential bug of jQuery 1.8.

These two lines causes IE8 to hang big time:

try{ pools= $.unique(pool.add(window.top.document)) }

Put aside the in my opinion correct expectation for jQuery to be able to decide whether two document objects are unique or not (afterall jQuery works just fine with document, right?), I'm thinking about making the comparison myself to work around this:

try{ if (pool[0] != top.document) pools= pool.add(top.document) }

It should have the exact same effect without the need for $.unique().

@ghost ghost assigned pisi Aug 15, 2012

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Aug 15, 2012

Owner

Ok, so as was explained to me, what I have there was actually a misuse of $.unique(), so that is a big no no for our purpose. I have big hopes for the workaround outlined above. Will test and see.

Owner

pisi commented Aug 15, 2012

Ok, so as was explained to me, what I have there was actually a misuse of $.unique(), so that is a big no no for our purpose. I have big hopes for the workaround outlined above. Will test and see.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Sep 4, 2012

Owner

For those, who want to give the workaround, it is available in fix-pools branch. If you do, please let me know if it resolved your issue or not. Thanks!

Owner

pisi commented Sep 4, 2012

For those, who want to give the workaround, it is available in fix-pools branch. If you do, please let me know if it resolved your issue or not. Thanks!

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Oct 10, 2012

Owner

Fix for this just made it into the development branch

Owner

pisi commented Oct 10, 2012

Fix for this just made it into the development branch

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Oct 11, 2012

Owner

I've just verified this working in:

  • IE 8 and 9 on Win7
  • IE 6 and 7 on WinXP
Owner

pisi commented Oct 11, 2012

I've just verified this working in:

  • IE 8 and 9 on Win7
  • IE 6 and 7 on WinXP

@pisi pisi closed this Oct 11, 2012

pisi added a commit that referenced this issue Feb 23, 2013

Reel 1.2.1
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 23, 2013

Owner

Merged into master and included in today's version 1.2.1 release.

Owner

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment