New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jquery 1.9.1 Incompatibility #174

Closed
Devolv opened this Issue Feb 16, 2013 · 4 comments

Comments

Projects
None yet
2 participants
@Devolv

Devolv commented Feb 16, 2013

Running the latest Jquery 1.9.1 results in the following Error:

TypeError: k.browser is undefined

When switching back to legacy Jquery 1.8.3, Reel works again.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 17, 2013

Owner

In other words: time for a patch.

Thanks for the notice!

Owner

pisi commented Feb 17, 2013

In other words: time for a patch.

Thanks for the notice!

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 20, 2013

Owner

Code on the [development branch] is jQuery 1.9 compatible (in fact it works well with 2.0 beta too!) and is to be released as Reel 1.2.1 within few days.

Owner

pisi commented Feb 20, 2013

Code on the [development branch] is jQuery 1.9 compatible (in fact it works well with 2.0 beta too!) and is to be released as Reel 1.2.1 within few days.

@pisi pisi closed this Feb 20, 2013

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 20, 2013

Owner

@dtrunk90, thanks very much for sharing your fix, which I noticed just now. Kudos to you, sir! The fix indeed does make the trick. I applied a similar solution and though I realize the check there is to specifically catch IE, I came up with a stack of regular expressions ($.reel.re.ua) to identify the browser on my own. It basically is an optimized version of what's in the jQuery Migrate poly-fill plugin (whose full logic I employed in tests, which support this feature). However, thank you very much for your effort, Danny :)

Owner

pisi commented Feb 20, 2013

@dtrunk90, thanks very much for sharing your fix, which I noticed just now. Kudos to you, sir! The fix indeed does make the trick. I applied a similar solution and though I realize the check there is to specifically catch IE, I came up with a stack of regular expressions ($.reel.re.ua) to identify the browser on my own. It basically is an optimized version of what's in the jQuery Migrate poly-fill plugin (whose full logic I employed in tests, which support this feature). However, thank you very much for your effort, Danny :)

pisi added a commit that referenced this issue Feb 20, 2013

pisi added a commit that referenced this issue Feb 23, 2013

Reel 1.2.1
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 23, 2013

Owner

Merged into master and included in today's version 1.2.1 release.

Owner

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment