.unreel() failure with non-wheelable #175

Closed
danielocdh opened this Issue Feb 21, 2013 · 10 comments

Comments

Projects
None yet
2 participants
@danielocdh

Hello, first of all thanks for this wonderful plugin.

I'm using reel inside a slide, I need to to stop it when the slide is not visible, and restart it when the slide comes visible again.

If there is a way to pause the reel, then at another moment, reset it and resume the playback please let me know.

I can provide the page for this problem, but privately, is that possible?

I try to unreel like this:
$reel_element.unreel();
OR
$('#container .reel-overlay').unreel();
OR
$('#container').unreel();
OR
$.reel.instances.unreel();

for all of them I get this error on opera and chrome:

opera:

Error thrown at line 2, column 49306 in <anonymous function: acceptData>(e) in jquery.js:
    var t=e.nodeName&&st.noData[e.nodeName.toLowerCase()];
called from line 2, column 732 in i(e, n, r, i) in jquery.js:
    if(st.acceptData(e))
called from line 2, column 49128 in <anonymous function: _data>(e, t, n) in jquery.js:
    return i(e,t,n,!0)
called from line 3, column 5636 in <anonymous function: remove>(e, t, n, r, i) in jquery.js:
    var o,a,s,u,l,c,f,p,d,h,g,m=st.hasData(e)&&st._data(e);
called from line 3, column 6289 in <anonymous function: remove>(e, t, n, r, i) in jquery.js:
    st.event.remove(e,d+t[l],n,r,!0);
called from line 3, column 6289 in <anonymous function: remove>(e, t, n, r, i) in jquery.js:
    st.event.remove(e,d+t[l],n,r,!0);
called from line 3, column 6289 in <anonymous function: remove>(e, t, n, r, i) in jquery.js:
    st.event.remove(e,d+t[l],n,r,!0);
...

chrome:

Uncaught RangeError: Maximum call stack size exceeded
st.event.remove
st.event.remove
st.event.remove
st.event.remove
st.event.remove
st.event.remove
st.event.remove
st.event.remove
...

I'm using version Version: 1.2-devel Updated: 2013-02-21, because I need "scrollable" option, also using jquery 1.9.0

Thank you

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 21, 2013

Owner

Hi, please show me on petr at vostrel dot cz. Despite your issue being very interesting, be aware that you are working with a non-stable development code which is right now being prepared for release and still has some issues.

Owner

pisi commented Feb 21, 2013

Hi, please show me on petr at vostrel dot cz. Despite your issue being very interesting, be aware that you are working with a non-stable development code which is right now being prepared for release and still has some issues.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 21, 2013

Owner

I just re-run the complete test suite on both Chrome on Opera (on both Windows and Mac) and despite everyone of these tests use .unreel() eventually, none of them resulted in loops described above. Dude, you gotta show me, really! ;)

Owner

pisi commented Feb 21, 2013

I just re-run the complete test suite on both Chrome on Opera (on both Windows and Mac) and despite everyone of these tests use .unreel() eventually, none of them resulted in loops described above. Dude, you gotta show me, really! ;)

@danielocdh

This comment has been minimized.

Show comment
Hide comment
@danielocdh

danielocdh Feb 21, 2013

mail with link to test site send, thank you

mail with link to test site send, thank you

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 21, 2013

Owner

Nothing arrived yet.. (unless you were a viagra spam.. :D)

Owner

pisi commented Feb 21, 2013

Nothing arrived yet.. (unless you were a viagra spam.. :D)

@danielocdh

This comment has been minimized.

Show comment
Hide comment
@danielocdh

danielocdh Feb 21, 2013

I sent the mail again from gmail and hotmail, this time copy pasted your email from your profile and changed the subject, just in case the previous mails didn't arrive, sorry for the spam if they did. Thank you.

I sent the mail again from gmail and hotmail, this time copy pasted your email from your profile and changed the subject, just in case the previous mails didn't arrive, sorry for the spam if they did. Thank you.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 22, 2013

Owner

Still nothing :/ Mighty strange! Try vostrel at gmail com and also please try sending me an e-mail without the link (to test if some link guard isn't acting upon us). Thanks.

Owner

pisi commented Feb 22, 2013

Still nothing :/ Mighty strange! Try vostrel at gmail com and also please try sending me an e-mail without the link (to test if some link guard isn't acting upon us). Thanks.

pisi added a commit that referenced this issue Feb 22, 2013

In jQuery 1.9.x, binding of empty string (`""`) no longer results in …
…no binding and an empty binding is created instead. For non-wheelable setups this leads to stack overflow issues when unbinding such events at teardown. Using `null` avoids this and fixes issue #175
@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 22, 2013

Owner

Funnily enough the solution was to replace String nothing ("") with real nothing (null) ;) to restore, how jQuery didn't bind prior to 1.9.x. A real bug after all! Was a tough one to spot here.

Fix merged into the development branch, so @danielocdh, please grab the latest patched code and confirm it is working in your application. Thanks!

Owner

pisi commented Feb 22, 2013

Funnily enough the solution was to replace String nothing ("") with real nothing (null) ;) to restore, how jQuery didn't bind prior to 1.9.x. A real bug after all! Was a tough one to spot here.

Fix merged into the development branch, so @danielocdh, please grab the latest patched code and confirm it is working in your application. Thanks!

@ghost ghost assigned pisi Feb 22, 2013

@danielocdh

This comment has been minimized.

Show comment
Hide comment
@danielocdh

danielocdh Feb 22, 2013

Working perfectly on the example now, even that my example was a bit bad coded. Thanks a lot.

Working perfectly on the example now, even that my example was a bit bad coded. Thanks a lot.

@danielocdh danielocdh closed this Feb 22, 2013

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 22, 2013

Owner

Awesome!

Owner

pisi commented Feb 22, 2013

Awesome!

pisi referenced this issue in farandal/Reel Feb 23, 2013

pisi added a commit that referenced this issue Feb 23, 2013

Reel 1.2.1
========

* new exciting multi-row stitched panorama possibility
* full compatibility with jQuery 1.9.x and 2.0 beta
* one less dependency (disableTextSelect)
* fixed page scrolling on touch devices
* maximal throw velocity via `throwable`
* image assets folder
* fixed image sequence allowing for odd starting points

Includes fixes for issues #129, #140, #174, #175, #142, #146, #144, #129, #172
@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Feb 23, 2013

Owner

Merged into master and included in today's version 1.2.1 release.

Owner

pisi commented Feb 23, 2013

Merged into master and included in today's version 1.2.1 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment