Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

what If image -reel not found? #179

Closed
nicolasFernandez opened this issue Mar 14, 2013 · 3 comments
Closed

what If image -reel not found? #179

nicolasFernandez opened this issue Mar 14, 2013 · 3 comments
Assignees
Milestone

Comments

@nicolasFernandez
Copy link

If could have the possibility to set some sort of message like '360 view not available'

@pisi
Copy link
Owner

pisi commented Mar 22, 2013

Catching network or server errors on client (particularly for images) is not 100% reliable, however, possible. The real problem is that Reel tries to stay human language agnostic, so such message most likely won't be coded in. But I'm thinking about forwarding the image error or abort events you'll be able to listened to and act if loading error arrises.

Something is a sense of:

$('#my_image').reel();
$('#my_image').on('error', function(){
  // This would fire for each image which failed to load
});

@ghost ghost assigned pisi Mar 22, 2013
pisi added a commit that referenced this issue May 17, 2013
@pisi
Copy link
Owner

pisi commented May 17, 2013

@nicolasFernandez I implemented the above proposal and it works as described therein. Enjoy :)

@pisi pisi closed this as completed May 17, 2013
@pisi
Copy link
Owner

pisi commented Nov 5, 2013

Released today as part of v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants