what If image -reel not found? #179

Closed
nicolasFernandez opened this Issue Mar 14, 2013 · 3 comments

Comments

Projects
None yet
2 participants
@nicolasFernandez

If could have the possibility to set some sort of message like '360 view not available'

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Mar 22, 2013

Owner

Catching network or server errors on client (particularly for images) is not 100% reliable, however, possible. The real problem is that Reel tries to stay human language agnostic, so such message most likely won't be coded in. But I'm thinking about forwarding the image error or abort events you'll be able to listened to and act if loading error arrises.

Something is a sense of:

$('#my_image').reel();
$('#my_image').on('error', function(){
  // This would fire for each image which failed to load
});
Owner

pisi commented Mar 22, 2013

Catching network or server errors on client (particularly for images) is not 100% reliable, however, possible. The real problem is that Reel tries to stay human language agnostic, so such message most likely won't be coded in. But I'm thinking about forwarding the image error or abort events you'll be able to listened to and act if loading error arrises.

Something is a sense of:

$('#my_image').reel();
$('#my_image').on('error', function(){
  // This would fire for each image which failed to load
});

@ghost ghost assigned pisi Mar 22, 2013

pisi added a commit that referenced this issue May 17, 2013

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi May 17, 2013

Owner

@nicolasFernandez I implemented the above proposal and it works as described therein. Enjoy :)

Owner

pisi commented May 17, 2013

@nicolasFernandez I implemented the above proposal and it works as described therein. Enjoy :)

@pisi pisi closed this May 17, 2013

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi Nov 5, 2013

Owner

Released today as part of v1.3.0

Owner

pisi commented Nov 5, 2013

Released today as part of v1.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment